Title: [224538] trunk/LayoutTests
Revision
224538
Author
[email protected]
Date
2017-11-07 11:29:31 -0800 (Tue, 07 Nov 2017)

Log Message

LayoutTest http/tests/security/cross-frame-access-put.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179195

Reviewed by Ryosuke Niwa.

Fix flaky test by calling the testRunner functions as early as possible, not in
the onload event handler.

* http/tests/security/cross-frame-access-put.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (224537 => 224538)


--- trunk/LayoutTests/ChangeLog	2017-11-07 19:21:52 UTC (rev 224537)
+++ trunk/LayoutTests/ChangeLog	2017-11-07 19:29:31 UTC (rev 224538)
@@ -1,3 +1,15 @@
+2017-11-07  Chris Dumez  <[email protected]>
+
+        LayoutTest http/tests/security/cross-frame-access-put.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=179195
+
+        Reviewed by Ryosuke Niwa.
+
+        Fix flaky test by calling the testRunner functions as early as possible, not in
+        the onload event handler.
+
+        * http/tests/security/cross-frame-access-put.html:
+
 2017-11-07  Maciej Stachowiak  <[email protected]>
 
         Update WPT encoding test suite to the latest version.

Modified: trunk/LayoutTests/http/tests/security/cross-frame-access-put.html (224537 => 224538)


--- trunk/LayoutTests/http/tests/security/cross-frame-access-put.html	2017-11-07 19:21:52 UTC (rev 224537)
+++ trunk/LayoutTests/http/tests/security/cross-frame-access-put.html	2017-11-07 19:29:31 UTC (rev 224538)
@@ -3,6 +3,11 @@
 <iframe src="" style=""></iframe>
 <pre id="console"></pre>
 <script>
+if (window.testRunner) {
+        testRunner.dumpAsText();
+        testRunner.waitUntilDone();
+    }
+
 function log(s)
 {
     document.getElementById("console").appendChild(document.createTextNode(s + "\n"));
@@ -21,14 +26,6 @@
 
 window.addEventListener("message", test, false);
 
-window._onload_ = function()
-{
-    if (window.testRunner) {
-        testRunner.dumpAsText();
-        testRunner.waitUntilDone();
-    }
-}
-
 function test(message) {
     alert(message.data);
     // FIXME: This test should use fast/window/resources/window-properties.js instead of a custom list.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to