Title: [224588] trunk/Source/bmalloc
- Revision
- 224588
- Author
- [email protected]
- Date
- 2017-11-08 11:30:36 -0800 (Wed, 08 Nov 2017)
Log Message
Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context]
https://bugs.webkit.org/show_bug.cgi?id=179427
Reviewed by Saam Barati.
Tweak the conditional to suppress the warning.
* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
Modified Paths
Diff
Modified: trunk/Source/bmalloc/ChangeLog (224587 => 224588)
--- trunk/Source/bmalloc/ChangeLog 2017-11-08 19:08:48 UTC (rev 224587)
+++ trunk/Source/bmalloc/ChangeLog 2017-11-08 19:30:36 UTC (rev 224588)
@@ -1,3 +1,15 @@
+2017-11-08 Michael Catanzaro <[email protected]>
+
+ Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context]
+ https://bugs.webkit.org/show_bug.cgi?id=179427
+
+ Reviewed by Saam Barati.
+
+ Tweak the conditional to suppress the warning.
+
+ * bmalloc/Gigacage.cpp:
+ (Gigacage::ensureGigacage):
+
2017-11-07 Saam Barati <[email protected]>
We should PROT_NONE the Gigacage runway so OOB accesses crash
Modified: trunk/Source/bmalloc/bmalloc/Gigacage.cpp (224587 => 224588)
--- trunk/Source/bmalloc/bmalloc/Gigacage.cpp 2017-11-08 19:08:48 UTC (rev 224587)
+++ trunk/Source/bmalloc/bmalloc/Gigacage.cpp 2017-11-08 19:30:36 UTC (rev 224588)
@@ -156,7 +156,7 @@
BCRASH();
}
- if (GIGACAGE_RUNWAY) {
+ if (GIGACAGE_RUNWAY > 0) {
char* runway = reinterpret_cast<char*>(base) + totalSize - GIGACAGE_RUNWAY;
// Make OOB accesses into the runway crash.
vmRevokePermissions(runway, GIGACAGE_RUNWAY);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
