Title: [224604] trunk/Source/WebCore
- Revision
- 224604
- Author
- [email protected]
- Date
- 2017-11-08 15:54:15 -0800 (Wed, 08 Nov 2017)
Log Message
REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=179442
Reviewed by Simon Fraser.
Disable the assertion when the web thread is used.
* dom/Document.cpp:
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayout):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (224603 => 224604)
--- trunk/Source/WebCore/ChangeLog 2017-11-08 23:38:55 UTC (rev 224603)
+++ trunk/Source/WebCore/ChangeLog 2017-11-08 23:54:15 UTC (rev 224604)
@@ -1,3 +1,16 @@
+2017-11-08 Ryosuke Niwa <[email protected]>
+
+ REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded
+ https://bugs.webkit.org/show_bug.cgi?id=179442
+
+ Reviewed by Simon Fraser.
+
+ Disable the assertion when the web thread is used.
+
+ * dom/Document.cpp:
+ (WebCore::Document::updateStyleIfNeeded):
+ (WebCore::Document::updateLayout):
+
2017-11-08 Colin Bendell <[email protected]>
Added mime type check to the picture source preloader to avoid downloading incompatible resources.
Modified: trunk/Source/WebCore/dom/Document.cpp (224603 => 224604)
--- trunk/Source/WebCore/dom/Document.cpp 2017-11-08 23:38:55 UTC (rev 224603)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-11-08 23:54:15 UTC (rev 224604)
@@ -1939,7 +1939,9 @@
}
// The early exit for needsStyleRecalc() is needed when updateWidgetPositions() is called in runOrScheduleAsynchronousTasks().
+#if !USE(WEB_THREAD)
RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()));
+#endif
resolveStyle();
return true;
@@ -1956,9 +1958,10 @@
ASSERT_NOT_REACHED();
return;
}
+#if !USE(WEB_THREAD)
RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()));
+#endif
-
RenderView::RepaintRegionAccumulator repaintRegionAccumulator(renderView());
if (HTMLFrameOwnerElement* owner = ownerElement())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
