Title: [224619] trunk/Source/WebKit
- Revision
- 224619
- Author
- [email protected]
- Date
- 2017-11-08 22:05:07 -0800 (Wed, 08 Nov 2017)
Log Message
Include a more complete block signature in public headers to avoid potential -Wstrict-prototypes warnings
https://bugs.webkit.org/show_bug.cgi?id=179466
Patch by Joseph Pecoraro <[email protected]> on 2017-11-08
Reviewed by Dan Bernstein.
* UIProcess/API/Cocoa/WKHTTPCookieStore.h:
* UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
(-[WKHTTPCookieStore setCookie:completionHandler:]):
(-[WKHTTPCookieStore deleteCookie:completionHandler:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224618 => 224619)
--- trunk/Source/WebKit/ChangeLog 2017-11-09 05:35:34 UTC (rev 224618)
+++ trunk/Source/WebKit/ChangeLog 2017-11-09 06:05:07 UTC (rev 224619)
@@ -1,3 +1,15 @@
+2017-11-08 Joseph Pecoraro <[email protected]>
+
+ Include a more complete block signature in public headers to avoid potential -Wstrict-prototypes warnings
+ https://bugs.webkit.org/show_bug.cgi?id=179466
+
+ Reviewed by Dan Bernstein.
+
+ * UIProcess/API/Cocoa/WKHTTPCookieStore.h:
+ * UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
+ (-[WKHTTPCookieStore setCookie:completionHandler:]):
+ (-[WKHTTPCookieStore deleteCookie:completionHandler:]):
+
2017-11-08 Jeremy Jones <[email protected]>
Make WKFullScreenWidnowController more robust against modification by the embedding app.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.h (224618 => 224619)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.h 2017-11-09 05:35:34 UTC (rev 224618)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.h 2017-11-09 06:05:07 UTC (rev 224619)
@@ -56,12 +56,12 @@
@param cookie The cookie to set.
@param completionHandler A block to invoke once the cookie has been stored.
*/
-- (void)setCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler;
+- (void)setCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)(void))completionHandler;
/*! @abstract Delete the specified cookie.
@param completionHandler A block to invoke once the cookie has been deleted.
*/
-- (void)deleteCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler;
+- (void)deleteCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)(void))completionHandler;
/*! @abstract Adds a WKHTTPCookieStoreObserver object with the cookie store.
@param observer The observer object to add.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm (224618 => 224619)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm 2017-11-09 05:35:34 UTC (rev 224618)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm 2017-11-09 06:05:07 UTC (rev 224619)
@@ -84,7 +84,7 @@
});
}
-- (void)setCookie:(NSHTTPCookie *)cookie completionHandler:(void (^)())completionHandler
+- (void)setCookie:(NSHTTPCookie *)cookie completionHandler:(void (^)(void))completionHandler
{
_cookieStore->setCookie(cookie, [handler = adoptNS([completionHandler copy])]() {
auto rawHandler = (void (^)())handler.get();
@@ -94,7 +94,7 @@
}
-- (void)deleteCookie:(NSHTTPCookie *)cookie completionHandler:(void (^)())completionHandler
+- (void)deleteCookie:(NSHTTPCookie *)cookie completionHandler:(void (^)(void))completionHandler
{
_cookieStore->deleteCookie(cookie, [handler = adoptNS([completionHandler copy])]() {
auto rawHandler = (void (^)())handler.get();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
