Title: [224658] trunk/Tools
- Revision
- 224658
- Author
- [email protected]
- Date
- 2017-11-09 17:48:40 -0800 (Thu, 09 Nov 2017)
Log Message
webkitpy: Unify version parsing code
https://bugs.webkit.org/show_bug.cgi?id=179426
<rdar://problem/35415191>
Unreviewed fix to r224657.
* Scripts/webkitpy/common/version.py:
(Version.__init__): Check if an object is iterable.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (224657 => 224658)
--- trunk/Tools/ChangeLog 2017-11-10 00:58:32 UTC (rev 224657)
+++ trunk/Tools/ChangeLog 2017-11-10 01:48:40 UTC (rev 224658)
@@ -4,6 +4,17 @@
https://bugs.webkit.org/show_bug.cgi?id=179426
<rdar://problem/35415191>
+ Unreviewed fix to r224657.
+
+ * Scripts/webkitpy/common/version.py:
+ (Version.__init__): Check if an object is iterable.
+
+2017-11-09 Jonathan Bedard <[email protected]>
+
+ webkitpy: Unify version parsing code
+ https://bugs.webkit.org/show_bug.cgi?id=179426
+ <rdar://problem/35415191>
+
Reviewed by David Kilzer.
webkitpy needs to parse version strings or version lists frequently. Rather than
Modified: trunk/Tools/Scripts/webkitpy/common/version.py (224657 => 224658)
--- trunk/Tools/Scripts/webkitpy/common/version.py 2017-11-10 00:58:32 UTC (rev 224657)
+++ trunk/Tools/Scripts/webkitpy/common/version.py 2017-11-10 01:48:40 UTC (rev 224658)
@@ -20,6 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import collections
class Version(object):
@@ -36,7 +37,7 @@
for i in xrange(len(ver.split('.'))):
self[i] = ver.split('.')[i]
return
- elif isinstance(ver, list) or isinstance(ver, Version) or isinstance(ver, tuple):
+ elif isinstance(ver, Version) or isinstance(ver, collections.Iterable):
for i in xrange(len(ver)):
self[i] = ver[i]
return
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
