Title: [224761] trunk/Source/WebInspectorUI
- Revision
- 224761
- Author
- [email protected]
- Date
- 2017-11-13 11:17:09 -0800 (Mon, 13 Nov 2017)
Log Message
Web Inspector: Give DataGrid/Table Header ContextMenu a section header to better describe its functions
https://bugs.webkit.org/show_bug.cgi?id=179560
Patch by Joseph Pecoraro <[email protected]> on 2017-11-13
Reviewed by Matt Baker.
* Localizations/en.lproj/localizedStrings.js:
New string.
* UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype._contextMenuInHeader):
* UserInterface/Views/Table.js:
(WI.Table.prototype._handleHeaderContextMenu):
Include a disabled context menu item as a section header.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (224760 => 224761)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-11-13 19:14:47 UTC (rev 224760)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-11-13 19:17:09 UTC (rev 224761)
@@ -1,3 +1,19 @@
+2017-11-13 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Give DataGrid/Table Header ContextMenu a section header to better describe its functions
+ https://bugs.webkit.org/show_bug.cgi?id=179560
+
+ Reviewed by Matt Baker.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ New string.
+
+ * UserInterface/Views/DataGrid.js:
+ (WI.DataGrid.prototype._contextMenuInHeader):
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype._handleHeaderContextMenu):
+ Include a disabled context menu item as a section header.
+
2017-11-12 Carlos Garcia Campos <[email protected]>
REGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests.
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (224760 => 224761)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-11-13 19:14:47 UTC (rev 224760)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-11-13 19:17:09 UTC (rev 224761)
@@ -306,6 +306,7 @@
localizedStrings["Disabled"] = "Disabled";
localizedStrings["Disk Cache"] = "Disk Cache";
localizedStrings["Display"] = "Display";
+localizedStrings["Displayed Columns"] = "Displayed Columns";
localizedStrings["Do not fade unexecuted code"] = "Do not fade unexecuted code";
localizedStrings["Dock to bottom of window"] = "Dock to bottom of window";
localizedStrings["Dock to side of window"] = "Dock to side of window";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (224760 => 224761)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2017-11-13 19:14:47 UTC (rev 224760)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2017-11-13 19:17:09 UTC (rev 224761)
@@ -1632,6 +1632,9 @@
if (!didAddSeparator) {
contextMenu.appendSeparator();
didAddSeparator = true;
+
+ const disabled = true;
+ contextMenu.appendItem(WI.UIString("Displayed Columns"), () => {}, disabled);
}
contextMenu.appendCheckboxItem(columnInfo.title, () => {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (224760 => 224761)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2017-11-13 19:14:47 UTC (rev 224760)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2017-11-13 19:17:09 UTC (rev 224761)
@@ -1250,6 +1250,9 @@
contextMenu.appendSeparator();
+ const disabled = true;
+ contextMenu.appendItem(WI.UIString("Displayed Columns"), () => {}, disabled);
+
for (let [columnIdentifier, column] of this._columnSpecs) {
if (column.locked)
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
