Title: [224775] trunk
- Revision
- 224775
- Author
- [email protected]
- Date
- 2017-11-13 13:41:55 -0800 (Mon, 13 Nov 2017)
Log Message
Unreviewed, rolling out r224763.
https://bugs.webkit.org/show_bug.cgi?id=179632
test fails on iOS (Requested by alexchristensen on #webkit).
Reverted changeset:
"Add tests to ensure that <source> tags are only preloaded
when the `type`"
https://bugs.webkit.org/show_bug.cgi?id=179231
https://trac.webkit.org/changeset/224763
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (224774 => 224775)
--- trunk/LayoutTests/ChangeLog 2017-11-13 21:29:47 UTC (rev 224774)
+++ trunk/LayoutTests/ChangeLog 2017-11-13 21:41:55 UTC (rev 224775)
@@ -1,3 +1,17 @@
+2017-11-13 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r224763.
+ https://bugs.webkit.org/show_bug.cgi?id=179632
+
+ test fails on iOS (Requested by alexchristensen on #webkit).
+
+ Reverted changeset:
+
+ "Add tests to ensure that <source> tags are only preloaded
+ when the `type`"
+ https://bugs.webkit.org/show_bug.cgi?id=179231
+ https://trac.webkit.org/changeset/224763
+
2017-11-13 Antti Koivisto <[email protected]>
Don't eliminate whitespace renderer if the previous sibling is a text renderer
Deleted: trunk/LayoutTests/http/tests/preload/picture-type-expected.txt (224774 => 224775)
--- trunk/LayoutTests/http/tests/preload/picture-type-expected.txt 2017-11-13 21:29:47 UTC (rev 224774)
+++ trunk/LayoutTests/http/tests/preload/picture-type-expected.txt 2017-11-13 21:41:55 UTC (rev 224775)
@@ -1,40 +0,0 @@
-PASS internals.isPreloaded('resources/base-image1.png?0'); is true
-PASS internals.isPreloaded('resources/preload-test.jpg?0'); is false
-PASS internals.isPreloaded('resources/base-image1.png?1'); is true
-PASS internals.isPreloaded('resources/preload-test.jpg?1'); is false
-PASS internals.isPreloaded('resources/base-image1.png?2'); is true
-PASS internals.isPreloaded('resources/preload-test.jpg?2'); is false
-PASS internals.isPreloaded('resources/base-image1.png?3'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?3'); is true
-PASS internals.isPreloaded('resources/base-image1.png?4'); is false
-PASS internals.isPreloaded('resources/base-image2.png?4'); is false
-PASS internals.isPreloaded('resources/base-image3.png?4'); is true
-PASS internals.isPreloaded('resources/preload-test.jpg?4'); is false
-PASS internals.isPreloaded('resources/base-image1.png?5'); is false
-PASS internals.isPreloaded('resources/base-image2.png?5'); is false
-PASS internals.isPreloaded('resources/base-image3.png?5'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?5'); is true
-PASS internals.isPreloaded('resources/base-image1.png?6'); is true
-PASS internals.isPreloaded('resources/preload-test.jpg?6'); is false
-PASS internals.isPreloaded('resources/base-image1.png?7'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?7'); is true
-PASS internals.isPreloaded('resources/base-image1.png?8'); is true
-PASS internals.isPreloaded('resources/preload-test.jpg?8'); is false
-PASS internals.isPreloaded('resources/base-image1.png?9'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?9'); is true
-PASS internals.isPreloaded('resources/base-image1.png?10'); is true
-PASS internals.isPreloaded('resources/base-image2.png?10'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?10'); is false
-PASS internals.isPreloaded('resources/base-image1.png?11'); is false
-PASS internals.isPreloaded('resources/base-image2.png?11'); is true
-PASS internals.isPreloaded('resources/preload-test.jpg?11'); is false
-PASS internals.isPreloaded('resources/base-image1.png?12'); is true
-PASS internals.isPreloaded('resources/base-image2.png?12'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?12'); is false
-PASS internals.isPreloaded('resources/base-image1.png?13'); is false
-PASS internals.isPreloaded('resources/base-image2.png?13'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?13'); is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/http/tests/preload/picture-type.html (224774 => 224775)
--- trunk/LayoutTests/http/tests/preload/picture-type.html 2017-11-13 21:29:47 UTC (rev 224774)
+++ trunk/LayoutTests/http/tests/preload/picture-type.html 2017-11-13 21:41:55 UTC (rev 224775)
@@ -1,126 +0,0 @@
-<html>
-<head>
- <script src=""
- <script src=""
-</head>
-<body>
-<script>
- if (window.testRunner && window.internals) {
- testRunner.dumpAsText();
-
- shouldBeTrue("internals.isPreloaded('resources/base-image1.png?0');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?0');");
- shouldBeTrue("internals.isPreloaded('resources/base-image1.png?1');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?1');");
- shouldBeTrue("internals.isPreloaded('resources/base-image1.png?2');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?2');");
- shouldBeFalse("internals.isPreloaded('resources/base-image1.png?3');");
- shouldBeTrue("internals.isPreloaded('resources/preload-test.jpg?3');");
-
- shouldBeFalse("internals.isPreloaded('resources/base-image1.png?4');");
- shouldBeFalse("internals.isPreloaded('resources/base-image2.png?4');");
- shouldBeTrue("internals.isPreloaded('resources/base-image3.png?4');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?4');");
-
- shouldBeFalse("internals.isPreloaded('resources/base-image1.png?5');");
- shouldBeFalse("internals.isPreloaded('resources/base-image2.png?5');");
- shouldBeFalse("internals.isPreloaded('resources/base-image3.png?5');");
- shouldBeTrue("internals.isPreloaded('resources/preload-test.jpg?5');");
-
- shouldBeTrue("internals.isPreloaded('resources/base-image1.png?6');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?6');");
- shouldBeFalse("internals.isPreloaded('resources/base-image1.png?7');");
- shouldBeTrue("internals.isPreloaded('resources/preload-test.jpg?7');");
-
- shouldBeTrue("internals.isPreloaded('resources/base-image1.png?8');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?8');");
-
- shouldBeFalse("internals.isPreloaded('resources/base-image1.png?9');");
- shouldBeTrue("internals.isPreloaded('resources/preload-test.jpg?9');");
-
- shouldBeTrue("internals.isPreloaded('resources/base-image1.png?10');");
- shouldBeFalse("internals.isPreloaded('resources/base-image2.png?10');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?10');");
-
- shouldBeFalse("internals.isPreloaded('resources/base-image1.png?11');");
- shouldBeTrue("internals.isPreloaded('resources/base-image2.png?11');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?11');");
-
- shouldBeTrue("internals.isPreloaded('resources/base-image1.png?12');");
- shouldBeFalse("internals.isPreloaded('resources/base-image2.png?12');");
- shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?12');");
-
- shouldBeFalse("internals.isPreloaded('resources/base-image1.png?13');");
- shouldBeFalse("internals.isPreloaded('resources/base-image2.png?13');");
- shouldBeTrue("internals.isPreloaded('resources/preload-test.jpg?13');");
- }
-</script>
-<!-- Control group -->
-<picture>
- <source srcset="resources/base-image1.png?0">
- <img src=""
-</picture>
-<!-- All permutations of type, media, srcset and sizes -->
-
-<picture>
- <source type="image/png" srcset="resources/base-image1.png?1">
- <img src=""
-</picture>
-<picture>
- <source srcset="resources/base-image1.png?2" type="image/png">
- <img src=""
-</picture>
-<picture>
- <source type="image/bad" srcset="resources/base-image1.png?3">
- <img src=""
-</picture>
-<picture>
- <source type="image/png" sizes="200px" srcset="resources/base-image1.png?4 100w, resources/base-image3.png?4 800w, resources/base-image2.png?4 1000w">
- <img src=""
-</picture>
-<picture>
- <source type="image/bad" sizes="200px" srcset="resources/base-image1.png?5 100w, resources/base-image3.png?5 800w, resources/base-image2.png?5 1000w" >
- <img src=""
-</picture>
-<picture>
- <source type="image/png" media="(min-width: 1px)" srcset="resources/base-image1.png?6">
- <img src=""
-</picture>
-<picture>
- <source type="image/bad" media="(min-width: 1px)" srcset="resources/base-image1.png?7">
- <img src=""
-</picture>
-
-<!-- Duplicate attributes -->
-<picture>
- <source type="image/png" type="image/bad" srcset="resources/base-image1.png?8">
- <img src=""
-</picture>
-<picture>
- <source type="image/bad" type="image/png" srcset="resources/base-image1.png?9">
- <img src=""
-</picture>
-<!-- Multiple sources -->
-<picture>
- <source type="image/png" media="(min-width: 1px)" srcset="resources/base-image1.png?10">
- <source type="image/png" media="(min-width: 1px)" srcset="resources/base-image2.png?10">
- <img src=""
-</picture>
-<picture>
- <source type="image/bad" media="(min-width: 1px)" srcset="resources/base-image1.png?11">
- <source type="image/png" media="(min-width: 1px)" srcset="resources/base-image2.png?11">
- <img src=""
-</picture>
-<picture>
- <source type="image/png" media="(min-width: 1px)" srcset="resources/base-image1.png?12">
- <source type="image/bad" media="(min-width: 1px)" srcset="resources/base-image2.png?12">
- <img src=""
-</picture>
-<picture>
- <source type="image/bad" media="(min-width: 1px)" srcset="resources/base-image1.png?13">
- <source type="image/invalid" media="(min-width: 1px)" srcset="resources/base-image2.png?13">
- <img src=""
-</picture>
-
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (224774 => 224775)
--- trunk/Source/WebCore/ChangeLog 2017-11-13 21:29:47 UTC (rev 224774)
+++ trunk/Source/WebCore/ChangeLog 2017-11-13 21:41:55 UTC (rev 224775)
@@ -1,3 +1,17 @@
+2017-11-13 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r224763.
+ https://bugs.webkit.org/show_bug.cgi?id=179632
+
+ test fails on iOS (Requested by alexchristensen on #webkit).
+
+ Reverted changeset:
+
+ "Add tests to ensure that <source> tags are only preloaded
+ when the `type`"
+ https://bugs.webkit.org/show_bug.cgi?id=179231
+ https://trac.webkit.org/changeset/224763
+
2017-11-13 Antti Koivisto <[email protected]>
Don't eliminate whitespace renderer if the previous sibling is a text renderer
Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp (224774 => 224775)
--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2017-11-13 21:29:47 UTC (rev 224774)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2017-11-13 21:41:55 UTC (rev 224775)
@@ -36,7 +36,6 @@
#include "LinkLoader.h"
#include "LinkRelAttribute.h"
#include "Logging.h"
-#include "MIMETypeRegistry.h"
#include "MediaList.h"
#include "MediaQueryEvaluator.h"
#include "RenderView.h"
@@ -122,7 +121,7 @@
processAttribute(attributeName, attributeValue, document, pictureState);
}
- if (m_tagId == TagId::Source && !pictureState.isEmpty() && !pictureState.last() && m_mediaMatched && m_typeMatched && !m_srcSetAttribute.isEmpty()) {
+ if (m_tagId == TagId::Source && !pictureState.isEmpty() && !pictureState.last() && m_mediaMatched && !m_srcSetAttribute.isEmpty()) {
auto sourceSize = SizesAttributeParser(m_sizesAttribute, document).length();
ImageCandidate imageCandidate = bestFitSourceForImageAttributes(m_deviceScaleFactor, m_urlToLoad, m_srcSetAttribute, sourceSize);
@@ -220,11 +219,6 @@
LOG(MediaQueries, "HTMLPreloadScanner %p processAttribute evaluating media queries", this);
m_mediaMatched = MediaQueryEvaluator { document.printing() ? "print" : "screen", document, documentElement ? documentElement->computedStyle() : nullptr }.evaluate(mediaSet.get());
}
- if (match(attributeName, typeAttr) && m_typeAttribute.isNull()) {
- // when multiple type attributes present: first value wins, ignore subsequent (to match ImageElement parser and Blink behaviours)
- m_typeAttribute = attributeValue;
- m_typeMatched &= MIMETypeRegistry::isSupportedImageOrSVGMIMEType(m_typeAttribute);
- }
break;
case TagId::Script:
if (match(attributeName, typeAttr)) {
@@ -347,7 +341,6 @@
String m_srcSetAttribute;
String m_sizesAttribute;
bool m_mediaMatched { true };
- bool m_typeMatched { true };
String m_charset;
String m_crossOriginMode;
bool m_linkIsStyleSheet;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
