Title: [224827] trunk/Source/WebKit
- Revision
- 224827
- Author
- [email protected]
- Date
- 2017-11-14 11:50:30 -0800 (Tue, 14 Nov 2017)
Log Message
Remove assertions added in r224791
https://bugs.webkit.org/show_bug.cgi?id=178751#c10
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
I had added assertions that sandbox extension handle consumption succeeds.
In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
to give access to a directory that does not exist and consumption fails. We want it to fail,
so my optimistic addition of a success assertion was incorrect. The test passes without it
and behaves like it used to.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224826 => 224827)
--- trunk/Source/WebKit/ChangeLog 2017-11-14 19:44:18 UTC (rev 224826)
+++ trunk/Source/WebKit/ChangeLog 2017-11-14 19:50:30 UTC (rev 224827)
@@ -1,3 +1,18 @@
+2017-11-14 Alex Christensen <[email protected]>
+
+ Remove assertions added in r224791
+ https://bugs.webkit.org/show_bug.cgi?id=178751#c10
+
+ * NetworkProcess/mac/RemoteNetworkingContext.mm:
+ (WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
+ * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
+ (WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
+ I had added assertions that sandbox extension handle consumption succeeds.
+ In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
+ to give access to a directory that does not exist and consumption fails. We want it to fail,
+ so my optimistic addition of a success assertion was incorrect. The test passes without it
+ and behaves like it used to.
+
2017-11-14 Tim Horton <[email protected]>
Don't use -[NSString stringWithFormat:] to build defaults keys
Modified: trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm (224826 => 224827)
--- trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2017-11-14 19:44:18 UTC (rev 224826)
+++ trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2017-11-14 19:50:30 UTC (rev 224827)
@@ -93,10 +93,8 @@
else
base = SessionTracker::getIdentifierBase();
- if (!sessionID.isEphemeral()) {
- bool result = SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
- ASSERT_UNUSED(result, result);
- }
+ if (!sessionID.isEphemeral())
+ SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
RetainPtr<CFHTTPCookieStorageRef> uiProcessCookieStorage;
if (!parameters.uiProcessCookieStorageIdentifier.isEmpty())
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm (224826 => 224827)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm 2017-11-14 19:44:18 UTC (rev 224826)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm 2017-11-14 19:50:30 UTC (rev 224827)
@@ -58,10 +58,8 @@
else
base = SessionTracker::getIdentifierBase();
- if (!sessionID.isEphemeral()) {
- bool result = SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
- ASSERT_UNUSED(result, result);
- }
+ if (!sessionID.isEphemeral())
+ SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
RetainPtr<CFHTTPCookieStorageRef> uiProcessCookieStorage;
if (!sessionID.isEphemeral())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
