Title: [224971] trunk
- Revision
- 224971
- Author
- [email protected]
- Date
- 2017-11-17 10:33:57 -0800 (Fri, 17 Nov 2017)
Log Message
ServiceWorker intercepted FetchRequest should have their referrer set appropriately.
https://bugs.webkit.org/show_bug.cgi?id=179803
Patch by Youenn Fablet <[email protected]> on 2017-11-17
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/service-workers/service-worker/referer.https-expected.txt:
* web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:
Source/WebCore:
Covered by updated tests.
* workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (224970 => 224971)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-11-17 18:27:29 UTC (rev 224970)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-11-17 18:33:57 UTC (rev 224971)
@@ -1,3 +1,13 @@
+2017-11-17 Youenn Fablet <[email protected]>
+
+ ServiceWorker intercepted FetchRequest should have their referrer set appropriately.
+ https://bugs.webkit.org/show_bug.cgi?id=179803
+
+ Reviewed by Chris Dumez.
+
+ * web-platform-tests/service-workers/service-worker/referer.https-expected.txt:
+ * web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:
+
2017-11-16 Commit Queue <[email protected]>
Unreviewed, rolling out r224921.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/referer.https-expected.txt (224970 => 224971)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/referer.https-expected.txt 2017-11-17 18:27:29 UTC (rev 224970)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/referer.https-expected.txt 2017-11-17 18:33:57 UTC (rev 224971)
@@ -1,4 +1,3 @@
+PASS Verify the referer
-FAIL Verify the referer assert_equals: expected "finish" but got "failure:Referer for request-headers.py must be https://localhost:9443/service-workers/service-worker/resources/referer-iframe.html but got https://localhost:9443/service-workers/service-worker/resources/fetch-rewrite-worker.js"
-
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt (224970 => 224971)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt 2017-11-17 18:27:29 UTC (rev 224970)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt 2017-11-17 18:33:57 UTC (rev 224971)
@@ -1,3 +1,3 @@
-FAIL Test FetchEvent.request passed to onfetch assert_equals: request.referrer expected "https://localhost:9443/service-workers/service-worker/request-end-to-end.https.html" but got ""
+FAIL Test FetchEvent.request passed to onfetch assert_equals: request.mode expected "navigate" but got "no-cors"
Modified: trunk/Source/WebCore/ChangeLog (224970 => 224971)
--- trunk/Source/WebCore/ChangeLog 2017-11-17 18:27:29 UTC (rev 224970)
+++ trunk/Source/WebCore/ChangeLog 2017-11-17 18:33:57 UTC (rev 224971)
@@ -1,3 +1,15 @@
+2017-11-17 Youenn Fablet <[email protected]>
+
+ ServiceWorker intercepted FetchRequest should have their referrer set appropriately.
+ https://bugs.webkit.org/show_bug.cgi?id=179803
+
+ Reviewed by Chris Dumez.
+
+ Covered by updated tests.
+
+ * workers/service/context/ServiceWorkerFetch.cpp:
+ (WebCore::ServiceWorkerFetch::dispatchFetchEvent):
+
2017-11-17 Joanmarie Diggs <[email protected]>
AX: [GTK] Regression: accessibility/gtk/aria-keyshortcuts.html fails after r224953
Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp (224970 => 224971)
--- trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp 2017-11-17 18:27:29 UTC (rev 224970)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp 2017-11-17 18:33:57 UTC (rev 224971)
@@ -93,9 +93,8 @@
{
ASSERT(globalScope.isServiceWorkerGlobalScope());
- // FIXME: Set request referrer.
auto requestHeaders = FetchHeaders::create(FetchHeaders::Guard::Immutable, HTTPHeaderMap { request.httpHeaderFields() });
- auto fetchRequest = FetchRequest::create(globalScope, FetchBody::fromFormData(request.httpBody()), WTFMove(requestHeaders), WTFMove(request), WTFMove(options), { });
+ auto fetchRequest = FetchRequest::create(globalScope, FetchBody::fromFormData(request.httpBody()), WTFMove(requestHeaders), WTFMove(request), WTFMove(options), request.httpReferrer());
// FIXME: Initialize other FetchEvent::Init fields.
FetchEvent::Init init;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
