Title: [224998] trunk/Tools
Revision
224998
Author
[email protected]
Date
2017-11-17 16:19:54 -0800 (Fri, 17 Nov 2017)

Log Message

Disable failing API tests for rdar://problem/35344202.

Unreviewed test gardening.

* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (224997 => 224998)


--- trunk/Tools/ChangeLog	2017-11-17 23:44:16 UTC (rev 224997)
+++ trunk/Tools/ChangeLog	2017-11-18 00:19:54 UTC (rev 224998)
@@ -1,3 +1,11 @@
+2017-11-17  Ryan Haddad  <[email protected]>
+
+        Disable failing API tests for rdar://problem/35344202.
+
+        Unreviewed test gardening.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
+
 2017-11-17  Joanmarie Diggs  <[email protected]>
 
         AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm (224997 => 224998)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm	2017-11-17 23:44:16 UTC (rev 224997)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm	2017-11-18 00:19:54 UTC (rev 224998)
@@ -187,6 +187,8 @@
     runTestWithWebsiteDataStore([WKWebsiteDataStore defaultDataStore]);
 }
 
+// FIXME: This should be removed once <rdar://problem/35344202> is resolved and bots are updated.
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <= 101301) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED <= 110102)
 TEST(WebKit, WKHTTPCookieStoreNonPersistent)
 {
     RetainPtr<WKWebsiteDataStore> nonPersistentDataStore;
@@ -215,6 +217,7 @@
     auto customDataStore = adoptNS([[WKWebsiteDataStore alloc] _initWithConfiguration:websiteDataStoreConfiguration.get()]);
     runTestWithWebsiteDataStore(customDataStore.get());
 }
+#endif // (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <= 101301) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED <= 110102)
 
 TEST(WebKit, CookieObserverCrash)
 {
@@ -256,6 +259,8 @@
 }
 @end
 
+// FIXME: This should be removed once <rdar://problem/35344202> is resolved and bots are updated.
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <= 101301) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED <= 110102)
 TEST(WebKit, WKHTTPCookieStoreWithoutProcessPool)
 {
     NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:[NSDictionary dictionaryWithObjectsAndKeys:@"127.0.0.1", NSHTTPCookieDomain, @"/", NSHTTPCookiePath, @"cookiename", NSHTTPCookieName, @"cookievalue", NSHTTPCookieValue, [NSDate distantFuture], NSHTTPCookieExpires, nil]];
@@ -305,4 +310,5 @@
     TestWebKitAPI::Util::run(&finished);
 #endif
 }
+#endif // (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <= 101301) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED <= 110102)
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to