Diff
Modified: trunk/LayoutTests/ChangeLog (225012 => 225013)
--- trunk/LayoutTests/ChangeLog 2017-11-18 04:46:30 UTC (rev 225012)
+++ trunk/LayoutTests/ChangeLog 2017-11-18 06:32:23 UTC (rev 225013)
@@ -1,3 +1,20 @@
+2017-11-17 Megan Gardner <[email protected]>
+
+ Rebaseline and/or turn on more iOS selection tests that either already pass, or need minimal visual tweaking
+ https://bugs.webkit.org/show_bug.cgi?id=179856
+
+ Reviewed by Myles C. Maxfield.
+
+ These tests all neither to either be minimally rebaselined, or they worked, but were marked as failing.
+ All were checked for flakiness, and none were found to be flakey on the open source bots.
+
+ * platform/ios-wk2/TestExpectations:
+ * platform/ios/editing/selection/extend-by-word-002-expected.txt:
+ * platform/ios/editing/selection/iframe-expected.png: Modified property svn:mime-type.
+ * platform/ios/editing/selection/iframe-expected.txt:
+ * platform/ios/editing/selection/inline-table-expected.png: Modified property svn:mime-type.
+ * platform/ios/editing/selection/inline-table-expected.txt:
+
2017-11-17 Zalan Bujtas <[email protected]>
Test case for r224995.
Modified: trunk/LayoutTests/platform/ios/editing/selection/extend-by-word-002-expected.txt (225012 => 225013)
--- trunk/LayoutTests/platform/ios/editing/selection/extend-by-word-002-expected.txt 2017-11-18 04:46:30 UTC (rev 225012)
+++ trunk/LayoutTests/platform/ios/editing/selection/extend-by-word-002-expected.txt 2017-11-18 06:32:23 UTC (rev 225013)
@@ -17,7 +17,7 @@
RenderListItem {LI} at (0,0) size 120x22
RenderListMarker at (-15,5) size 6x14: bullet
RenderInline (generated) at (0,0) size 15x26
- RenderText {#text} at (5,-5) size 15x26
+ RenderText at (5,-5) size 15x26
text run at (5,-5) width 15: "\x{B7} "
RenderText {#text} at (0,0) size 0x0
RenderInline {A} at (0,0) size 53x14 [color=#0000EE]
@@ -26,7 +26,7 @@
RenderListItem {LI} at (0,22) size 120x22
RenderListMarker at (-15,5) size 6x14: bullet
RenderInline (generated) at (0,0) size 15x26
- RenderText {#text} at (5,-5) size 15x26
+ RenderText at (5,-5) size 15x26
text run at (5,-5) width 15: "\x{B7} "
RenderText {#text} at (0,0) size 0x0
RenderInline {A} at (0,0) size 79x14 [color=#0000EE]
@@ -35,7 +35,7 @@
RenderListItem {LI} at (0,44) size 120x36
RenderListMarker at (-15,5) size 6x14: bullet
RenderInline (generated) at (0,0) size 15x26
- RenderText {#text} at (5,-5) size 15x26
+ RenderText at (5,-5) size 15x26
text run at (5,-5) width 15: "\x{B7} "
RenderText {#text} at (0,0) size 0x0
RenderInline {A} at (0,0) size 77x28 [color=#0000EE]
@@ -46,7 +46,7 @@
RenderListItem {LI} at (0,80) size 120x22
RenderListMarker at (-15,5) size 6x14: bullet
RenderInline (generated) at (0,0) size 15x26
- RenderText {#text} at (5,-5) size 15x26
+ RenderText at (5,-5) size 15x26
text run at (5,-5) width 15: "\x{B7} "
RenderText {#text} at (0,0) size 0x0
RenderInline {A} at (0,0) size 65x14 [color=#0000EE]
@@ -55,7 +55,7 @@
RenderListItem {LI} at (0,102) size 120x22
RenderListMarker at (-15,5) size 6x14: bullet
RenderInline (generated) at (0,0) size 15x26
- RenderText {#text} at (5,-5) size 15x26
+ RenderText at (5,-5) size 15x26
text run at (5,-5) width 15: "\x{B7} "
RenderText {#text} at (0,0) size 0x0
RenderInline {A} at (0,0) size 41x14 [color=#0000EE]
@@ -64,7 +64,7 @@
RenderListItem {LI} at (0,124) size 120x22
RenderListMarker at (-15,5) size 6x14: bullet
RenderInline (generated) at (0,0) size 15x26
- RenderText {#text} at (5,-5) size 15x26
+ RenderText at (5,-5) size 15x26
text run at (5,-5) width 15: "\x{B7} "
RenderText {#text} at (0,0) size 0x0
RenderInline {A} at (0,0) size 41x14 [color=#0000EE]
Modified: trunk/LayoutTests/platform/ios/editing/selection/iframe-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/ios/editing/selection/iframe-expected.txt (225012 => 225013)
--- trunk/LayoutTests/platform/ios/editing/selection/iframe-expected.txt 2017-11-18 04:46:30 UTC (rev 225012)
+++ trunk/LayoutTests/platform/ios/editing/selection/iframe-expected.txt 2017-11-18 06:32:23 UTC (rev 225013)
@@ -215,40 +215,40 @@
RenderBlock {DIV} at (0,0) size 384x82
RenderText {#text} at (0,10) size 82x19
text run at (0,10) width 82: "Inline Table:"
- RenderTable {TABLE} at (81,0) size 136x82 [border: (1px outset #808080)]
- RenderTableSection {TBODY} at (1,1) size 133x80
- RenderTableRow {TR} at (0,2) size 133x24
+ RenderTable {TABLE} at (81,0) size 134x82 [border: (1px outset #808080)]
+ RenderTableSection {TBODY} at (1,1) size 132x80
+ RenderTableRow {TR} at (0,2) size 132x24
RenderTableCell {TD} at (2,2) size 44x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 27x19
text run at (2,2) width 27: "One"
- RenderTableCell {TD} at (48,2) size 39x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderTableCell {TD} at (47,2) size 39x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 29x19
text run at (2,2) width 29: "Two"
- RenderTableCell {TD} at (89,2) size 42x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (87,2) size 43x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
RenderText {#text} at (2,2) size 38x19
text run at (2,2) width 38: "Three"
- RenderTableRow {TR} at (0,28) size 133x24
+ RenderTableRow {TR} at (0,28) size 132x24
RenderTableCell {TD} at (2,28) size 44x24 [border: (1px inset #808080)] [r=1 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 31x19
text run at (2,2) width 31: "Four"
- RenderTableCell {TD} at (48,28) size 39x24 [border: (1px inset #808080)] [r=1 c=1 rs=1 cs=1]
+ RenderTableCell {TD} at (47,28) size 39x24 [border: (1px inset #808080)] [r=1 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 29x19
text run at (2,2) width 29: "Five"
- RenderTableCell {TD} at (89,28) size 42x24 [border: (1px inset #808080)] [r=1 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (87,28) size 43x24 [border: (1px inset #808080)] [r=1 c=2 rs=1 cs=1]
RenderText {#text} at (2,2) size 22x19
text run at (2,2) width 22: "Six"
- RenderTableRow {TR} at (0,54) size 133x24
+ RenderTableRow {TR} at (0,54) size 132x24
RenderTableCell {TD} at (2,54) size 44x24 [border: (1px inset #808080)] [r=2 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 40x19
text run at (2,2) width 40: "Seven"
- RenderTableCell {TD} at (48,54) size 39x24 [border: (1px inset #808080)] [r=2 c=1 rs=1 cs=1]
+ RenderTableCell {TD} at (47,54) size 39x24 [border: (1px inset #808080)] [r=2 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 35x19
text run at (2,2) width 35: "Eight"
- RenderTableCell {TD} at (89,54) size 42x24 [border: (1px inset #808080)] [r=2 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (87,54) size 43x24 [border: (1px inset #808080)] [r=2 c=2 rs=1 cs=1]
RenderText {#text} at (2,2) size 32x19
text run at (2,2) width 32: "Nine"
- RenderText {#text} at (216,10) size 67x19
- text run at (216,10) width 67: "The End..."
+ RenderText {#text} at (214,10) size 67x19
+ text run at (214,10) width 67: "The End..."
RenderText {#text} at (452,187) size 67x19
text run at (452,187) width 67: " the end ..."
caret: position 1 of child 0 {#text} of child 1 {DIV} of child 3 {DIV} of body
Modified: trunk/LayoutTests/platform/ios/editing/selection/inline-table-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/ios/editing/selection/inline-table-expected.txt (225012 => 225013)
--- trunk/LayoutTests/platform/ios/editing/selection/inline-table-expected.txt 2017-11-18 04:46:30 UTC (rev 225012)
+++ trunk/LayoutTests/platform/ios/editing/selection/inline-table-expected.txt 2017-11-18 06:32:23 UTC (rev 225013)
@@ -155,38 +155,38 @@
RenderBlock {DIV} at (0,0) size 784x82
RenderText {#text} at (0,10) size 82x19
text run at (0,10) width 82: "Inline Table:"
- RenderTable {TABLE} at (81,0) size 136x82 [border: (1px outset #808080)]
- RenderTableSection {TBODY} at (1,1) size 133x80
- RenderTableRow {TR} at (0,2) size 133x24
+ RenderTable {TABLE} at (81,0) size 134x82 [border: (1px outset #808080)]
+ RenderTableSection {TBODY} at (1,1) size 132x80
+ RenderTableRow {TR} at (0,2) size 132x24
RenderTableCell {TD} at (2,2) size 44x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 27x19
text run at (2,2) width 27: "One"
- RenderTableCell {TD} at (48,2) size 39x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderTableCell {TD} at (47,2) size 39x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 29x19
text run at (2,2) width 29: "Two"
- RenderTableCell {TD} at (89,2) size 42x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (87,2) size 43x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
RenderText {#text} at (2,2) size 38x19
text run at (2,2) width 38: "Three"
- RenderTableRow {TR} at (0,28) size 133x24
+ RenderTableRow {TR} at (0,28) size 132x24
RenderTableCell {TD} at (2,28) size 44x24 [border: (1px inset #808080)] [r=1 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 31x19
text run at (2,2) width 31: "Four"
- RenderTableCell {TD} at (48,28) size 39x24 [border: (1px inset #808080)] [r=1 c=1 rs=1 cs=1]
+ RenderTableCell {TD} at (47,28) size 39x24 [border: (1px inset #808080)] [r=1 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 29x19
text run at (2,2) width 29: "Five"
- RenderTableCell {TD} at (89,28) size 42x24 [border: (1px inset #808080)] [r=1 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (87,28) size 43x24 [border: (1px inset #808080)] [r=1 c=2 rs=1 cs=1]
RenderText {#text} at (2,2) size 22x19
text run at (2,2) width 22: "Six"
- RenderTableRow {TR} at (0,54) size 133x24
+ RenderTableRow {TR} at (0,54) size 132x24
RenderTableCell {TD} at (2,54) size 44x24 [border: (1px inset #808080)] [r=2 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 40x19
text run at (2,2) width 40: "Seven"
- RenderTableCell {TD} at (48,54) size 39x24 [border: (1px inset #808080)] [r=2 c=1 rs=1 cs=1]
+ RenderTableCell {TD} at (47,54) size 39x24 [border: (1px inset #808080)] [r=2 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 35x19
text run at (2,2) width 35: "Eight"
- RenderTableCell {TD} at (89,54) size 42x24 [border: (1px inset #808080)] [r=2 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (87,54) size 43x24 [border: (1px inset #808080)] [r=2 c=2 rs=1 cs=1]
RenderText {#text} at (2,2) size 32x19
text run at (2,2) width 32: "Nine"
- RenderText {#text} at (216,10) size 67x19
- text run at (216,10) width 67: "The End..."
+ RenderText {#text} at (214,10) size 67x19
+ text run at (214,10) width 67: "The End..."
caret: position 1 of child 0 {#text} of child 1 {DIV} of child 3 {DIV} of body
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (225012 => 225013)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-11-18 04:46:30 UTC (rev 225012)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-11-18 06:32:23 UTC (rev 225013)
@@ -1083,30 +1083,6 @@
editing/execCommand/nsresponder-outdent.html [ Failure Pass ]
editing/execCommand/print.html [ Failure Pass ]
editing/execCommand/remove-list-from-range-selection.html [ Failure Pass ]
-editing/selection/extend-by-word-002.html [ Failure Pass ]
-editing/selection/focus_editable_html.html [ Failure Pass ]
-editing/selection/iframe.html [ Failure ImageOnlyFailure Pass ]
-editing/selection/image-before-linebreak.html [ Failure Pass ]
-editing/selection/inline-table.html [ Failure Pass ]
-editing/selection/leave-requested-block.html [ Failure Pass ]
-editing/selection/mixed-editability-3.html [ Failure Pass ]
-editing/selection/mixed-editability-4.html [ Failure Pass ]
-editing/selection/mixed-editability-5.html [ Failure Pass ]
-editing/selection/mixed-editability-8.html [ Failure Pass ]
-editing/selection/mixed-editability-9.html [ Failure Pass ]
-editing/selection/move-3875618-fix.html [ Failure Pass ]
-editing/selection/move-3875641-fix.html [ Failure Pass ]
-editing/selection/move-backwords-by-word-001.html [ Failure Pass ]
-editing/selection/move-between-blocks-no-001.html [ Failure Pass ]
-editing/selection/move-between-blocks-yes-001.html [ Failure Pass ]
-editing/selection/move-by-character-001.html [ Failure Pass ]
-editing/selection/move-by-character-002.html [ Failure Pass ]
-editing/selection/move-by-character-003.html [ Failure Pass ]
-editing/selection/move-by-character-004.html [ Failure Pass ]
-editing/selection/move-by-character-005.html [ Failure Pass ]
-editing/selection/move-by-character-6.html [ Failure Pass ]
-editing/selection/move-by-line-002.html [ Failure Pass ]
-editing/selection/move-by-sentence-001.html [ Failure Pass ]
webkit.org/b/149087 http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html [ Pass Timeout ]
platform/ios/ios/fast/coordinates/document-elementFromPoint.html [ Failure Pass ]
transitions/transition-on-element-with-content.html [ Failure Pass ]