Title: [225174] trunk/Source/WebCore
- Revision
- 225174
- Author
- [email protected]
- Date
- 2017-11-27 09:05:47 -0800 (Mon, 27 Nov 2017)
Log Message
[CoordGraphics] CoordinatedGraphicsLayer doesn't need to inherit from TextureMapperPlatformLayer::Client
https://bugs.webkit.org/show_bug.cgi?id=180036
Reviewed by Carlos Garcia Campos.
There's no reason CoordinatedGraphicsLayer should inherit from
TextureMapperPlatformLayer::Client. CoordinatedGraphicsLayer objects are
not used anywhere through that type, and all the overridden methods are
empty anyway. The TextureMapperPlatformLayer::Client class (along with
TextureMapperPlatformLayer) is nowadays only used in the direct
TextureMapper implementation of GraphicsLayer.
No new tests -- no change in behavior.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::platformLayerWillBeDestroyed): Deleted.
(WebCore::CoordinatedGraphicsLayer::setPlatformLayerNeedsDisplay): Deleted.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (225173 => 225174)
--- trunk/Source/WebCore/ChangeLog 2017-11-27 16:54:00 UTC (rev 225173)
+++ trunk/Source/WebCore/ChangeLog 2017-11-27 17:05:47 UTC (rev 225174)
@@ -1,3 +1,24 @@
+2017-11-27 Zan Dobersek <[email protected]>
+
+ [CoordGraphics] CoordinatedGraphicsLayer doesn't need to inherit from TextureMapperPlatformLayer::Client
+ https://bugs.webkit.org/show_bug.cgi?id=180036
+
+ Reviewed by Carlos Garcia Campos.
+
+ There's no reason CoordinatedGraphicsLayer should inherit from
+ TextureMapperPlatformLayer::Client. CoordinatedGraphicsLayer objects are
+ not used anywhere through that type, and all the overridden methods are
+ empty anyway. The TextureMapperPlatformLayer::Client class (along with
+ TextureMapperPlatformLayer) is nowadays only used in the direct
+ TextureMapper implementation of GraphicsLayer.
+
+ No new tests -- no change in behavior.
+
+ * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+ (WebCore::CoordinatedGraphicsLayer::platformLayerWillBeDestroyed): Deleted.
+ (WebCore::CoordinatedGraphicsLayer::setPlatformLayerNeedsDisplay): Deleted.
+ * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
+
2017-11-27 Antoine Quint <[email protected]>
Pressing the space bar while watching a fullscreen video doesn't play or pause
Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (225173 => 225174)
--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2017-11-27 16:54:00 UTC (rev 225173)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2017-11-27 17:05:47 UTC (rev 225174)
@@ -1209,16 +1209,6 @@
client().notifyAnimationStarted(this, "", m_lastAnimationStartTime);
}
-#if USE(COORDINATED_GRAPHICS_THREADED)
-void CoordinatedGraphicsLayer::platformLayerWillBeDestroyed()
-{
-}
-
-void CoordinatedGraphicsLayer::setPlatformLayerNeedsDisplay()
-{
-}
-#endif
-
} // namespace WebCore
#endif // USE(COORDINATED_GRAPHICS)
Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h (225173 => 225174)
--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h 2017-11-27 16:54:00 UTC (rev 225173)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h 2017-11-27 17:05:47 UTC (rev 225174)
@@ -31,7 +31,6 @@
#include "Image.h"
#include "IntSize.h"
#include "TextureMapperAnimation.h"
-#include "TextureMapperPlatformLayer.h"
#include "TiledBackingStore.h"
#include "TiledBackingStoreClient.h"
#include "TransformationMatrix.h"
@@ -55,9 +54,6 @@
class CoordinatedGraphicsLayer : public GraphicsLayer
, public TiledBackingStoreClient
-#if USE(COORDINATED_GRAPHICS_THREADED)
- , public TextureMapperPlatformLayer::Client
-#endif
, public CoordinatedImageBacking::Host {
public:
explicit CoordinatedGraphicsLayer(Type, GraphicsLayerClient&);
@@ -147,10 +143,6 @@
void syncPlatformLayer();
void updatePlatformLayer();
-#if USE(COORDINATED_GRAPHICS_THREADED)
- void platformLayerWillBeDestroyed() override;
- void setPlatformLayerNeedsDisplay() override;
-#endif
void setDebugBorder(const Color&, float width) override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
