Title: [225196] trunk/Source/WebCore
- Revision
- 225196
- Author
- [email protected]
- Date
- 2017-11-27 15:04:32 -0800 (Mon, 27 Nov 2017)
Log Message
REGRESSION (r225142): Crashes when command clicking or force touching links
https://bugs.webkit.org/show_bug.cgi?id=180055
<rdar://problem/35703910>
Reviewed by Wenson Hsieh.
No new tests; affects an existing API test.
* editing/mac/DictionaryLookup.mm:
(WebCore::tokenRange):
The 'options' out argument from tokenRangeForString is autoreleased.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (225195 => 225196)
--- trunk/Source/WebCore/ChangeLog 2017-11-27 22:29:33 UTC (rev 225195)
+++ trunk/Source/WebCore/ChangeLog 2017-11-27 23:04:32 UTC (rev 225196)
@@ -1,3 +1,17 @@
+2017-11-27 Tim Horton <[email protected]>
+
+ REGRESSION (r225142): Crashes when command clicking or force touching links
+ https://bugs.webkit.org/show_bug.cgi?id=180055
+ <rdar://problem/35703910>
+
+ Reviewed by Wenson Hsieh.
+
+ No new tests; affects an existing API test.
+
+ * editing/mac/DictionaryLookup.mm:
+ (WebCore::tokenRange):
+ The 'options' out argument from tokenRangeForString is autoreleased.
+
2017-11-27 Dean Jackson <[email protected]>
Implement OffscreenCanvas.getContext("webgl")
Modified: trunk/Source/WebCore/editing/mac/DictionaryLookup.mm (225195 => 225196)
--- trunk/Source/WebCore/editing/mac/DictionaryLookup.mm 2017-11-27 22:29:33 UTC (rev 225195)
+++ trunk/Source/WebCore/editing/mac/DictionaryLookup.mm 2017-11-27 23:04:32 UTC (rev 225196)
@@ -62,9 +62,9 @@
if (!options)
return [classLULookupDefinitionModule tokenRangeForString:string range:range options:nullptr];
- NSDictionary *retainedOptions = nil;
- auto result = [classLULookupDefinitionModule tokenRangeForString:string range:range options:&retainedOptions];
- *options = adoptNS(retainedOptions);
+ NSDictionary *outOptions = nil;
+ auto result = [classLULookupDefinitionModule tokenRangeForString:string range:range options:&outOptions];
+ *options = outOptions;
return result;
END_BLOCK_OBJC_EXCEPTIONS;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
