Title: [225206] trunk/Tools
- Revision
- 225206
- Author
- [email protected]
- Date
- 2017-11-27 17:21:39 -0800 (Mon, 27 Nov 2017)
Log Message
Do not run webkitpy tests on multiple EWSes
https://bugs.webkit.org/show_bug.cgi?id=179834
Reviewed by Alexey Proskuryakov.
Do not run webkitpy tests in every EWS. We now have
a dedicated webkitpy test EWS.
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run): Do not run webkitpy tests in EWSes. These tests will still run
when --non-interactive option is not passed.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (225205 => 225206)
--- trunk/Tools/ChangeLog 2017-11-28 00:46:47 UTC (rev 225205)
+++ trunk/Tools/ChangeLog 2017-11-28 01:21:39 UTC (rev 225206)
@@ -1,3 +1,17 @@
+2017-11-27 Aakash Jain <[email protected]>
+
+ Do not run webkitpy tests on multiple EWSes
+ https://bugs.webkit.org/show_bug.cgi?id=179834
+
+ Reviewed by Alexey Proskuryakov.
+
+ Do not run webkitpy tests in every EWS. We now have
+ a dedicated webkitpy test EWS.
+
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ (RunTests.run): Do not run webkitpy tests in EWSes. These tests will still run
+ when --non-interactive option is not passed.
+
2017-11-27 Jonathan Bedard <[email protected]>
webkitpy: Better name-version mapping (Part 1)
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (225205 => 225206)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2017-11-28 00:46:47 UTC (rev 225205)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2017-11-28 01:21:39 UTC (rev 225206)
@@ -81,23 +81,12 @@
if not self._options.test:
return
- python_unittests_command = self._tool.deprecated_port().run_python_unittests_command()
- if python_unittests_command:
- _log.info("Running Python unit tests")
- if self._options.non_interactive:
- filesystem = self._tool.filesystem
- python_unittest_results_directory = self._tool.port_factory.get().python_unittest_results_directory()
- filesystem.maybe_make_directory(python_unittest_results_directory)
-
- python_unittests_command.append('--json')
- output = self._tool.executive.run_command(python_unittests_command, cwd=self._tool.scm().checkout_root, error_handler=Executive.ignore_error, return_stderr=False)
- filesystem.write_text_file(filesystem.join(python_unittest_results_directory, "results.json"), output)
- else:
+ if not self._options.non_interactive:
+ python_unittests_command = self._tool.deprecated_port().run_python_unittests_command()
+ if python_unittests_command:
+ _log.info("Running Python unit tests")
self._tool.executive.run_and_throw_if_fail(python_unittests_command, cwd=self._tool.scm().checkout_root)
- if not self._options.non_interactive:
- # FIXME: We should teach the commit-queue and the EWS how to run these tests.
-
perl_unittests_command = self._tool.deprecated_port().run_perl_unittests_command()
if perl_unittests_command:
_log.info("Running Perl unit tests")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
