Title: [225219] trunk
Revision
225219
Author
[email protected]
Date
2017-11-28 08:41:17 -0800 (Tue, 28 Nov 2017)

Log Message

REGRESSION(r225098): [WPE] Some features have changed of value (70 new failures)
https://bugs.webkit.org/show_bug.cgi?id=180004

Reviewed by Alex Christensen.

.:

Turn on ENABLE_ENCRYPTED_MEDIA and ENABLE_WEBGL2 when building with
ENABLE_EXPERIMENTAL_FEATURES. Also, let's stop turning off ENABLE_USERSELECT_ALL, as I doubt
there's any good reason for that.

* Source/cmake/OptionsWPE.cmake:

LayoutTests:

Remove failure expectations for layout tests that will stop failing once the buildbot master
is restarted. A restart is required for the build to begin using
-DENABLE_EXPERIMENTAL_FEATURES=ON.

* platform/wpe/TestExpectations:

Modified Paths

Diff

Modified: trunk/ChangeLog (225218 => 225219)


--- trunk/ChangeLog	2017-11-28 16:30:52 UTC (rev 225218)
+++ trunk/ChangeLog	2017-11-28 16:41:17 UTC (rev 225219)
@@ -1,3 +1,16 @@
+2017-11-28  Michael Catanzaro  <[email protected]>
+
+        REGRESSION(r225098): [WPE] Some features have changed of value (70 new failures)
+        https://bugs.webkit.org/show_bug.cgi?id=180004
+
+        Reviewed by Alex Christensen.
+
+        Turn on ENABLE_ENCRYPTED_MEDIA and ENABLE_WEBGL2 when building with
+        ENABLE_EXPERIMENTAL_FEATURES. Also, let's stop turning off ENABLE_USERSELECT_ALL, as I doubt
+        there's any good reason for that.
+
+        * Source/cmake/OptionsWPE.cmake:
+
 2017-11-27  Don Olmstead  <[email protected]>
 
         [CMake][Win] Conditionally select DLL CRT or static CRT

Modified: trunk/LayoutTests/ChangeLog (225218 => 225219)


--- trunk/LayoutTests/ChangeLog	2017-11-28 16:30:52 UTC (rev 225218)
+++ trunk/LayoutTests/ChangeLog	2017-11-28 16:41:17 UTC (rev 225219)
@@ -1,3 +1,16 @@
+2017-11-28  Michael Catanzaro  <[email protected]>
+
+        REGRESSION(r225098): [WPE] Some features have changed of value (70 new failures)
+        https://bugs.webkit.org/show_bug.cgi?id=180004
+
+        Reviewed by Alex Christensen.
+
+        Remove failure expectations for layout tests that will stop failing once the buildbot master
+        is restarted. A restart is required for the build to begin using
+        -DENABLE_EXPERIMENTAL_FEATURES=ON.
+
+        * platform/wpe/TestExpectations:
+
 2017-11-28  Antoine Quint  <[email protected]>
 
         Skip back and forward buttons should not hard-code their numeric amount in localised strings

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (225218 => 225219)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2017-11-28 16:30:52 UTC (rev 225218)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2017-11-28 16:41:17 UTC (rev 225219)
@@ -1027,75 +1027,3 @@
 webkit.org/b/179897 imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders.htm [ Failure ]
 
 webkit.org/b/179898 svg/animations/svglengthlist-animation-3.html [ Pass Failure ]
-
-# Some features have changed of value after r225098
-webkit.org/b/180004 fast/canvas/webgl/webgl2-buffer-targets.html [ Failure ]
-webkit.org/b/180004 fast/canvas/webgl/webgl2-context-creation.html [ Failure ]
-webkit.org/b/180004 fast/canvas/webgl/webgl2-getActiveUniforms.html [ Failure ]
-webkit.org/b/180004 fast/canvas/webgl/webgl2-runtime-flag.html [ Failure ]
-webkit.org/b/180004 fast/canvas/webgl/webgl2-texStorage.html [ Failure ]
-webkit.org/b/180004 fast/canvas/webgl/webgl2/constants.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-check-initdata-type.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-events.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-events.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-destroy-persistent-license.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-usage-record.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub.html [ Failure ]
-webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/idlharness.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeySession-close.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeySession-generateRequest.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeySession-load.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeySession-remove.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeySession-update.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeySystemAccess.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeys-createSession.html [ Failure ]
-webkit.org/b/180004 media/encrypted-media/mock-MediaKeys-setServerCertificate.html [ Failure ]
-webkit.org/b/180004 webgl/webgl-vertex-array-object-defined.html [ Failure ]
-webkit.org/b/180004 webgl/webgl2-rendering-context-defined.html [ Failure ]
-webkit.org/b/180004 webgl/webgl2-rendering-context-obtain.html [ Failure ]
-webkit.org/b/180004 fast/canvas/webgl/webgl2/bindings.html [ Timeout ]
-webkit.org/b/180004 fast/canvas/webgl/webgl2/sequences.html [ Timeout ]
-webkit.org/b/180004 media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html [ Timeout ]

Modified: trunk/Source/cmake/OptionsWPE.cmake (225218 => 225219)


--- trunk/Source/cmake/OptionsWPE.cmake	2017-11-28 16:30:52 UTC (rev 225218)
+++ trunk/Source/cmake/OptionsWPE.cmake	2017-11-28 16:41:17 UTC (rev 225219)
@@ -14,7 +14,7 @@
 # without approval from a WPE reviewer. There must be strong reason to support
 # changing the value of the option.
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XSLT PUBLIC ON)
@@ -31,8 +31,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOTIFICATIONS PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SMOOTH_SCROLLING PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)
-# FIXME: Should ENABLE_USERSELECT_ALL really be turned off?
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_USERSELECT_ALL PRIVATE OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 
 if (CMAKE_SYSTEM_NAME MATCHES "Linux")
     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE ON)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to