Title: [225226] trunk
- Revision
- 225226
- Author
- [email protected]
- Date
- 2017-11-28 10:50:59 -0800 (Tue, 28 Nov 2017)
Log Message
Web Audio's AnalyserNode.fftSize cannot be greater than 2048 in Safari; spec says it can be up to 32768
https://bugs.webkit.org/show_bug.cgi?id=180040
Patch by Noah Chase <[email protected]> on 2017-11-28
Reviewed by Alex Christensen.
Source/WebCore:
I fixed up the existing test/output for realtimeanalyser-fft-sizing.
one thing that I'm a bit unsure of here is whether or not there are other
places in WebKit's Web Audio implementation that use fftSize and
should have the wider range available (instead of capping out at
2048). based on a quick naive scan I think that there are.
* Modules/webaudio/RealtimeAnalyser.cpp:
LayoutTests:
* webaudio/realtimeanalyser-fft-sizing-expected.txt:
* webaudio/realtimeanalyser-fft-sizing.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (225225 => 225226)
--- trunk/LayoutTests/ChangeLog 2017-11-28 18:34:04 UTC (rev 225225)
+++ trunk/LayoutTests/ChangeLog 2017-11-28 18:50:59 UTC (rev 225226)
@@ -1,3 +1,13 @@
+2017-11-28 Noah Chase <[email protected]>
+
+ Web Audio's AnalyserNode.fftSize cannot be greater than 2048 in Safari; spec says it can be up to 32768
+ https://bugs.webkit.org/show_bug.cgi?id=180040
+
+ Reviewed by Alex Christensen.
+
+ * webaudio/realtimeanalyser-fft-sizing-expected.txt:
+ * webaudio/realtimeanalyser-fft-sizing.html:
+
2017-11-28 Ms2ger <[email protected]>
[WPE] Enable the wpt top-level directory.
Modified: trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt (225225 => 225226)
--- trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt 2017-11-28 18:34:04 UTC (rev 225225)
+++ trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt 2017-11-28 18:50:59 UTC (rev 225226)
@@ -27,13 +27,13 @@
PASS Exception thrown for illegal fftSize 1025.
PASS Successfully set legal fftSize 2048.
PASS Exception thrown for illegal fftSize 2049.
-PASS Exception thrown for illegal fftSize 4096.
+PASS Successfully set legal fftSize 4096.
PASS Exception thrown for illegal fftSize 4097.
-PASS Exception thrown for illegal fftSize 8192.
+PASS Successfully set legal fftSize 8192.
PASS Exception thrown for illegal fftSize 8193.
-PASS Exception thrown for illegal fftSize 16384.
+PASS Successfully set legal fftSize 16384.
PASS Exception thrown for illegal fftSize 16385.
-PASS Exception thrown for illegal fftSize 32768.
+PASS Successfully set legal fftSize 32768.
PASS Exception thrown for illegal fftSize 32769.
PASS Exception thrown for illegal fftSize 65536.
PASS Exception thrown for illegal fftSize 65537.
Modified: trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html (225225 => 225226)
--- trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html 2017-11-28 18:34:04 UTC (rev 225225)
+++ trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html 2017-11-28 18:50:59 UTC (rev 225226)
@@ -36,7 +36,7 @@
doTest(0, true);
doTest(1, true);
for (var i = 2; i <= 0x20000; i *= 2) {
- if (i >= 32 && i <= 2048)
+ if (i >= 32 && i <= 32768)
doTest(i, false);
else
doTest(i, true);
Modified: trunk/Source/WebCore/ChangeLog (225225 => 225226)
--- trunk/Source/WebCore/ChangeLog 2017-11-28 18:34:04 UTC (rev 225225)
+++ trunk/Source/WebCore/ChangeLog 2017-11-28 18:50:59 UTC (rev 225226)
@@ -1,3 +1,18 @@
+2017-11-28 Noah Chase <[email protected]>
+
+ Web Audio's AnalyserNode.fftSize cannot be greater than 2048 in Safari; spec says it can be up to 32768
+ https://bugs.webkit.org/show_bug.cgi?id=180040
+
+ Reviewed by Alex Christensen.
+
+ I fixed up the existing test/output for realtimeanalyser-fft-sizing.
+ one thing that I'm a bit unsure of here is whether or not there are other
+ places in WebKit's Web Audio implementation that use fftSize and
+ should have the wider range available (instead of capping out at
+ 2048). based on a quick naive scan I think that there are.
+
+ * Modules/webaudio/RealtimeAnalyser.cpp:
+
2017-11-28 Daniel Bates <[email protected]>
Add WebKitAdditions extension point to add user-agent stylesheet
Modified: trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp (225225 => 225226)
--- trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp 2017-11-28 18:34:04 UTC (rev 225225)
+++ trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp 2017-11-28 18:50:59 UTC (rev 225226)
@@ -47,7 +47,7 @@
const unsigned RealtimeAnalyser::DefaultFFTSize = 2048;
// All FFT implementations are expected to handle power-of-two sizes MinFFTSize <= size <= MaxFFTSize.
const unsigned RealtimeAnalyser::MinFFTSize = 32;
-const unsigned RealtimeAnalyser::MaxFFTSize = 2048;
+const unsigned RealtimeAnalyser::MaxFFTSize = 32768;
const unsigned RealtimeAnalyser::InputBufferSize = RealtimeAnalyser::MaxFFTSize * 2;
RealtimeAnalyser::RealtimeAnalyser()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
