Diff
Modified: trunk/LayoutTests/ChangeLog (225227 => 225228)
--- trunk/LayoutTests/ChangeLog 2017-11-28 18:54:05 UTC (rev 225227)
+++ trunk/LayoutTests/ChangeLog 2017-11-28 18:56:56 UTC (rev 225228)
@@ -1,3 +1,19 @@
+2017-11-28 Ryan Haddad <[email protected]>
+
+ [iOS] Rebaseline editing/execCommand tests
+ https://bugs.webkit.org/show_bug.cgi?id=180085
+
+ Unreviewed test gardening.
+
+ * platform/ios-wk2/TestExpectations:
+ * platform/ios-wk2/editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
+ * platform/ios-wk2/editing/execCommand/indent-pre-expected.txt: Added.
+ * platform/ios-wk2/editing/execCommand/selectAll-expected.txt: Added.
+ * platform/ios/editing/execCommand/create-list-with-hr-expected.txt:
+ * platform/ios/editing/execCommand/indent-selection-expected.txt:
+ * platform/ios/editing/execCommand/insert-list-and-stitch-expected.txt:
+ * platform/ios/editing/execCommand/nsresponder-indent-expected.txt:
+
2017-11-28 Noah Chase <[email protected]>
Web Audio's AnalyserNode.fftSize cannot be greater than 2048 in Safari; spec says it can be up to 32768
Modified: trunk/LayoutTests/platform/ios/editing/execCommand/create-list-with-hr-expected.txt (225227 => 225228)
--- trunk/LayoutTests/platform/ios/editing/execCommand/create-list-with-hr-expected.txt 2017-11-28 18:54:05 UTC (rev 225227)
+++ trunk/LayoutTests/platform/ios/editing/execCommand/create-list-with-hr-expected.txt 2017-11-28 18:56:56 UTC (rev 225228)
@@ -24,5 +24,4 @@
RenderBlock {HR} at (0,0) size 744x2 [border: (1px inset #000000)]
RenderBlock (anonymous) at (0,10) size 744x20
RenderListMarker at (-18,0) size 7x19: bullet
- RenderBlock (anonymous) at (0,46) size 784x0
caret: position 0 of child 0 {HR} of child 0 {LI} of child 0 {UL} of child 2 {DIV} of body
Modified: trunk/LayoutTests/platform/ios/editing/execCommand/indent-selection-expected.txt (225227 => 225228)
--- trunk/LayoutTests/platform/ios/editing/execCommand/indent-selection-expected.txt 2017-11-28 18:54:05 UTC (rev 225227)
+++ trunk/LayoutTests/platform/ios/editing/execCommand/indent-selection-expected.txt 2017-11-28 18:56:56 UTC (rev 225228)
@@ -27,7 +27,6 @@
RenderBlock {BLOCKQUOTE} at (40,40) size 704x20
RenderText {#text} at (0,0) size 40x19
text run at (0,0) width 40: "ipsum"
- RenderBlock (anonymous) at (0,60) size 784x0
RenderBlock {BLOCKQUOTE} at (40,76) size 744x60
RenderBlock {UL} at (0,0) size 744x60
RenderBlock {UL} at (40,0) size 704x60
@@ -54,6 +53,5 @@
RenderInline {SPAN} at (0,0) size 39x19
RenderText {#text} at (0,20) size 39x19
text run at (0,20) width 39: "Thing"
- RenderBlock (anonymous) at (0,212) size 784x0
selection start: position 0 of child 0 {#text} of child 0 {SPAN} of child 1 {BLOCKQUOTE} of child 4 {DIV} of body
selection end: position 5 of child 0 {#text} of child 3 {SPAN} of child 3 {BLOCKQUOTE} of child 4 {DIV} of body
Modified: trunk/LayoutTests/platform/ios/editing/execCommand/insert-list-and-stitch-expected.txt (225227 => 225228)
--- trunk/LayoutTests/platform/ios/editing/execCommand/insert-list-and-stitch-expected.txt 2017-11-28 18:54:05 UTC (rev 225227)
+++ trunk/LayoutTests/platform/ios/editing/execCommand/insert-list-and-stitch-expected.txt 2017-11-28 18:56:56 UTC (rev 225228)
@@ -35,5 +35,4 @@
RenderListMarker at (-21,0) size 16x19: "3"
RenderText {#text} at (0,0) size 23x19
text run at (0,0) width 23: "baz"
- RenderBlock (anonymous) at (0,76) size 784x0
caret: position 0 of child 0 {#text} of child 2 {LI} of child 0 {OL} of child 1 {DIV} of child 1 {DIV} of body
Modified: trunk/LayoutTests/platform/ios/editing/execCommand/nsresponder-indent-expected.txt (225227 => 225228)
--- trunk/LayoutTests/platform/ios/editing/execCommand/nsresponder-indent-expected.txt 2017-11-28 18:54:05 UTC (rev 225227)
+++ trunk/LayoutTests/platform/ios/editing/execCommand/nsresponder-indent-expected.txt 2017-11-28 18:56:56 UTC (rev 225228)
@@ -17,5 +17,4 @@
RenderBlock {BLOCKQUOTE} at (40,0) size 744x20
RenderText {#text} at (0,0) size 22x19
text run at (0,0) width 22: "foo"
- RenderBlock (anonymous) at (0,20) size 784x0
caret: position 0 of child 0 {#text} of child 0 {BLOCKQUOTE} of child 2 {DIV} of body
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (225227 => 225228)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-11-28 18:54:05 UTC (rev 225227)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-11-28 18:56:56 UTC (rev 225228)
@@ -593,14 +593,11 @@
editing/deleting/5144139-2.html [ Failure ]
editing/execCommand/button.html [ Failure ]
editing/execCommand/createLink.html [ Failure ]
-editing/execCommand/format-block-with-trailing-br.html [ Failure ]
editing/execCommand/hilitecolor.html [ Failure ]
-editing/execCommand/indent-pre.html [ Failure ]
editing/execCommand/query-command-state.html [ Failure ]
editing/execCommand/remove-format-multiple-elements-mac.html [ Failure ]
editing/execCommand/remove-format-multiple-elements-win.html [ Failure ]
editing/execCommand/remove-formatting-2.html [ Failure ]
-editing/execCommand/selectAll.html [ Failure ]
editing/execCommand/toggle-link-mac.html [ Failure ]
editing/execCommand/toggle-unlink-mac.html [ Failure ]
editing/execCommand/unlink.html [ Failure ]
@@ -747,26 +744,7 @@
# Editing tests that are flaky:
editing/caret/caret-color.html [ Failure Pass ]
editing/deleting/whitespace-pre-1.html [ Failure Pass ]
-editing/execCommand/format-block-with-braces.html [ Failure Pass ]
-editing/execCommand/format-block.html [ Failure Pass ]
-editing/execCommand/indent-nested-lists-1.html [ Failure Pass ]
-editing/execCommand/indent-nested-lists-2.html [ Failure Pass ]
-editing/execCommand/indent-nested-lists-3.html [ Failure Pass ]
-editing/execCommand/indent-nested-lists-4.html [ Failure Pass ]
-editing/execCommand/indent-nested-lists-5.html [ Failure Pass ]
-editing/execCommand/indent-nested-lists-6.html [ Failure Pass ]
-editing/execCommand/indent-nested-lists-7.html [ Failure Pass ]
editing/execCommand/indent-paragraphs.html [ Failure Pass ]
-editing/execCommand/indent-with-style.html [ Failure Pass ]
-editing/execCommand/insertHTML.html [ Failure Pass ]
-editing/execCommand/outdent-nested-lists-1.html [ Failure Pass ]
-editing/execCommand/outdent-nested-lists-2.html [ Failure Pass ]
-editing/execCommand/outdent-nested-lists-3.html [ Failure Pass ]
-editing/execCommand/outdent-nested-lists-4.html [ Failure Pass ]
-editing/execCommand/queryCommandState-01.html [ Failure Pass ]
-editing/execCommand/remove-formatting.html [ Failure Pass ]
-editing/execCommand/remove-list-items.html [ Failure Pass ]
-editing/execCommand/switch-list-type.html [ Failure Pass ]
editing/inserting/insert-thai-characters-001.html [ Failure Pass ]
editing/selection/find-in-text-control.html [ Failure Pass ]
editing/selection/skip-non-editable-1.html [ Failure Pass ]
@@ -1070,19 +1048,6 @@
webkit.org/b/145432 media/video-transformed-by-_javascript_.html [ Failure ]
# Latest iOS failures as of Sept 1, 2015
-editing/execCommand/4641880-1.html [ Failure Pass ]
-editing/execCommand/4641880-2.html [ Failure Pass ]
-editing/execCommand/create-list-with-hr.html [ Failure Pass ]
-editing/execCommand/indent-empty-root.html [ Failure Pass ]
-editing/execCommand/indent-list-item.html [ Failure Pass ]
-editing/execCommand/indent-selection.html [ Failure Pass ]
-editing/execCommand/insert-list-and-stitch.html [ Failure Pass ]
-editing/execCommand/insertHorizontalRule.html [ Failure Pass ]
-editing/execCommand/insertImage.html [ Failure Pass ]
-editing/execCommand/nsresponder-indent.html [ Failure Pass ]
-editing/execCommand/nsresponder-outdent.html [ Failure Pass ]
-editing/execCommand/print.html [ Failure Pass ]
-editing/execCommand/remove-list-from-range-selection.html [ Failure Pass ]
webkit.org/b/149087 http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html [ Pass Timeout ]
platform/ios/ios/fast/coordinates/document-elementFromPoint.html [ Failure Pass ]
transitions/transition-on-element-with-content.html [ Failure Pass ]
Added: trunk/LayoutTests/platform/ios-wk2/editing/execCommand/format-block-with-trailing-br-expected.txt (0 => 225228)
--- trunk/LayoutTests/platform/ios-wk2/editing/execCommand/format-block-with-trailing-br-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-wk2/editing/execCommand/format-block-with-trailing-br-expected.txt 2017-11-28 18:56:56 UTC (rev 225228)
@@ -0,0 +1,16 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 0 of PRE > DIV > BODY > HTML > #document to 0 of PRE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 784x42 [border: (1px solid #000000)]
+ RenderBlock {PRE} at (1,14) size 782x14
+ RenderText {#text} at (0,0) size 24x14
+ text run at (0,0) width 24: "Foo"
+caret: position 0 of child 0 {#text} of child 1 {PRE} of child 0 {DIV} of body
Added: trunk/LayoutTests/platform/ios-wk2/editing/execCommand/indent-pre-expected.txt (0 => 225228)
--- trunk/LayoutTests/platform/ios-wk2/editing/execCommand/indent-pre-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-wk2/editing/execCommand/indent-pre-expected.txt 2017-11-28 18:56:56 UTC (rev 225228)
@@ -0,0 +1,170 @@
+CONSOLE MESSAGE: line 48: Wrong focus offset: 5 instead of 4
+CONSOLE MESSAGE: line 44: Wrong node selected.
+CONSOLE MESSAGE: line 46: Wrong anchor offset: 8 instead of 0
+CONSOLE MESSAGE: line 48: Wrong focus offset: 5 instead of 4
+CONSOLE MESSAGE: line 41: Wrong end node type: [object HTMLBRElement]
+CONSOLE MESSAGE: line 44: Wrong node selected.
+| <html>
+| <head>
+| <body>
+| <p>
+| "This test tries to indent lines within pre tags. This test passes if it
+does not crash."
+| "
+"
+| <div>
+| contenteditable=""
+| "
+"
+| <blockquote>
+| style="margin: 0 0 0 40px; border: none; padding: 0px;"
+| <pre>
+| id="pre-basic"
+| "line one"
+| <pre>
+| id="pre-basic"
+| "line two
+"
+| <blockquote>
+| style="margin: 0 0 0 40px; border: none; padding: 0px;"
+| <pre>
+| "line three"
+| <pre>
+| "line four"
+| "
+
+"
+| <ul>
+| <li>
+| <pre>
+| id="pre-list"
+| "list one
+"
+| <blockquote>
+| style="margin: 0 0 0 40px; border: none; padding: 0px;"
+| "list two"
+| <br>
+| "list three"
+| "list four
+"
+| "
+
+"
+| <table>
+| "
+"
+| <tbody>
+| <tr>
+| <td>
+| <pre>
+| id="pre-table"
+| "table one<#selection-anchor>
+"
+| <blockquote>
+| style="margin: 0 0 0 40px; border: none; padding: 0px;"
+| <pre>
+| "table two"
+| <pre>
+| "table three<#selection-focus>"
+| <td>
+| "right cell"
+| "
+
+"
+| <div>
+| id="results"
+| "PASSED (did not crash)"
+| "
+"
+| "
+
+"
+| <a>
+| href=""
+| "indent"
+| "
+"
+| <a>
+| href=""
+| "outdent"
+| "
+"
+| <script>
+| src=""
+| "
+"
+| <script>
+| src=""
+| "
+"
+| <script>
+| "
+function setSelection(node)
+{
+ var textNode = node.firstChild;
+ if (textNode.nodeType != Node.TEXT_NODE)
+ throw "Wrong node type: " + textNode;
+ execSetSelectionCommand(textNode, 0, textNode);
+}
+
+function verifyTextSelection(startNode, startOffset, endNode, endOffset)
+{
+ if (startNode.nodeType != Node.TEXT_NODE)
+ console.log("Wrong start node type: " + startNode);
+ if (endNode.nodeType != Node.TEXT_NODE)
+ console.log("Wrong end node type: " + endNode);
+ var sel = window.getSelection();
+ if (sel.anchorNode != startNode || sel.focusNode != endNode)
+ console.log("Wrong node selected.");
+ if (sel.anchorOffset != startOffset)
+ console.log("Wrong anchor offset: " + sel.anchorOffset + " instead of " + startOffset);
+ if (sel.focusOffset != endOffset)
+ console.log("Wrong focus offset: " + sel.focusOffset + " instead of " + endOffset);
+}
+
+// Indent a single line in a pre and make sure the selection is correctly preserved.
+var pre = document.getElementById("pre-basic");
+setSelection(pre);
+execMoveSelectionForwardByCharacterCommand();
+execExtendSelectionForwardByWordCommand();
+document.execCommand("indent");
+verifyTextSelection(document.getElementsByTagName("pre")[0].firstChild, 1,
+ document.getElementsByTagName("pre")[0].firstChild, 4);
+
+// Indent 2 lines.
+setSelection(pre);
+execMoveSelectionForwardByLineCommand();
+execExtendSelectionForwardByLineCommand();
+execExtendSelectionForwardByWordCommand();
+document.execCommand("indent");
+if (document.getElementsByTagName("pre").length > 3) {
+ // FIXME: The selection for the anchorNode is wrong. It should stay at
+ // the beginning of "line three", but it moves to the end of "line 2".
+ verifyTextSelection(document.getElementsByTagName("pre")[2].firstChild, 0,
+ document.getElementsByTagName("pre")[3].firstChild, 4);
+} else {
+ console.log("Wrong number of pre nodes.");
+}
+
+// Indent <pre> lines in a list.
+pre = document.getElementById("pre-list");
+setSelection(pre);
+execMoveSelectionForwardByLineCommand();
+execExtendSelectionForwardByLineCommand();
+execExtendSelectionForwardByLineCommand();
+document.execCommand("indent");
+verifyTextSelection(document.getElementsByTagName("blockquote")[2].firstChild, 0,
+ document.getElementsByTagName("blockquote")[2].firstChild.nextSibling, 10);
+// Indenting <pre> lines in a table.
+pre = document.getElementById("pre-table");
+setSelection(pre);
+execMoveSelectionForwardByLineCommand();
+execExtendSelectionForwardByLineCommand();
+execExtendSelectionForwardByLineCommand();
+// FIXME: This is wrong. The pre tags get copied when they shouldn't be.
+// See https://bugs.webkit.org/show_bug.cgi?id=42009
+document.execCommand("indent");
+document.getElementById("results").innerText = "PASSED (did not crash)";
+"
+| "
+"
Added: trunk/LayoutTests/platform/ios-wk2/editing/execCommand/selectAll-expected.txt (0 => 225228)
--- trunk/LayoutTests/platform/ios-wk2/editing/execCommand/selectAll-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-wk2/editing/execCommand/selectAll-expected.txt 2017-11-28 18:56:56 UTC (rev 225228)
@@ -0,0 +1,54 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > SPAN > DIV > BODY > HTML > #document to 562 of #text > P > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 784x376 [border: (2px solid #FF0000)]
+ RenderBlock (anonymous) at (14,14) size 756x60
+ RenderInline {SPAN} at (0,0) size 756x58
+ RenderText {#text} at (0,1) size 756x58
+ text run at (0,1) width 756: "\"The quick brown fox jumps over the lazy dog\" uses every letter in the english"
+ text run at (755,1) width 1: " "
+ text run at (0,31) width 93: "language."
+ RenderBlock (anonymous) at (14,98) size 756x240
+ RenderBlock {P} at (0,0) size 756x240
+ RenderText {#text} at (0,1) size 756x238
+ text run at (0,1) width 458: "Here's to the crazy ones, the misfits, the rebels, "
+ text run at (457,1) width 192: "the trouble makers, "
+ text run at (648,1) width 92: "the round"
+ text run at (739,1) width 7: " "
+ text run at (0,31) width 242: "pegs in the square holes, "
+ text run at (241,31) width 346: "the ones who see things differently. "
+ text run at (586,31) width 170: "There not fond of"
+ text run at (755,31) width 1: " "
+ text run at (0,61) width 480: "rules, and they have no respect for the status quo, "
+ text run at (479,61) width 195: "you can quote then, "
+ text run at (673,61) width 81: "disagree"
+ text run at (753,61) width 3: " "
+ text run at (0,91) width 109: "with them, "
+ text run at (108,91) width 216: "glorify or vilify them, "
+ text run at (323,91) width 406: "about the only thing you can't do is ignore"
+ text run at (728,91) width 7: " "
+ text run at (0,121) width 60: "them. "
+ text run at (59,121) width 279: "Because they change things. "
+ text run at (337,121) width 349: "They push the human race forward. "
+ text run at (685,121) width 42: "And"
+ text run at (726,121) width 7: " "
+ text run at (0,151) width 430: "while some may see them as the crazy ones, "
+ text run at (429,151) width 146: "we see genius. "
+ text run at (574,151) width 116: "Because the"
+ text run at (689,151) width 7: " "
+ text run at (0,181) width 626: "people who are crazy enough to think they can change the world "
+ text run at (625,181) width 115: "are the ones"
+ text run at (739,181) width 7: " "
+ text run at (0,211) width 78: "who do."
+ RenderBlock (anonymous) at (14,362) size 756x0
+ RenderInline {SPAN} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
+selection start: position 0 of child 0 {#text} of child 1 {SPAN} of child 1 {DIV} of body
+selection end: position 562 of child 0 {#text} of child 1 {P} of child 1 {SPAN} of child 1 {DIV} of body
