Title: [225236] trunk/Tools
- Revision
- 225236
- Author
- [email protected]
- Date
- 2017-11-28 13:11:10 -0800 (Tue, 28 Nov 2017)
Log Message
Stop modifying self.expectations in TestExpectationLine.expected_behavior.
https://bugs.webkit.org/show_bug.cgi?id=180074
Reviewed by Simon Fraser.
In particular, getting the property multiple times on a skipped test
expectation line (which happens when using
`Tools/Scripts/run-webkit-tests --print-expectations` if a directory
containing multiple tests is skipped) would yield [pass, skip], then
[pass, skip, skip], then [pass, skip, skip, skip], and so on.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationLine.expected_behavior): copy self.expectations before modifying it.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (225235 => 225236)
--- trunk/Tools/ChangeLog 2017-11-28 21:10:14 UTC (rev 225235)
+++ trunk/Tools/ChangeLog 2017-11-28 21:11:10 UTC (rev 225236)
@@ -1,3 +1,19 @@
+2017-11-28 Ms2ger <[email protected]>
+
+ Stop modifying self.expectations in TestExpectationLine.expected_behavior.
+ https://bugs.webkit.org/show_bug.cgi?id=180074
+
+ Reviewed by Simon Fraser.
+
+ In particular, getting the property multiple times on a skipped test
+ expectation line (which happens when using
+ `Tools/Scripts/run-webkit-tests --print-expectations` if a directory
+ containing multiple tests is skipped) would yield [pass, skip], then
+ [pass, skip, skip], then [pass, skip, skip, skip], and so on.
+
+ * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+ (TestExpectationLine.expected_behavior): copy self.expectations before modifying it.
+
2017-11-14 Carlos Garcia Campos <[email protected]>
Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (225235 => 225236)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2017-11-28 21:10:14 UTC (rev 225235)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2017-11-28 21:11:10 UTC (rev 225236)
@@ -411,7 +411,7 @@
@property
def expected_behavior(self):
- expectations = self.expectations
+ expectations = self.expectations[:]
if "SLOW" in self.modifiers:
expectations += ["SLOW"]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
