Title: [225240] trunk/Tools
- Revision
- 225240
- Author
- [email protected]
- Date
- 2017-11-28 14:39:04 -0800 (Tue, 28 Nov 2017)
Log Message
Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
https://bugs.webkit.org/show_bug.cgi?id=118505
Reviewed by Joseph Pecoraro.
* Scripts/valgrind/suppressions.txt:
* Scripts/webkitpy/port/leakdetector.py:
(LeakDetector._callstacks_to_exclude_from_leaks):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (225239 => 225240)
--- trunk/Tools/ChangeLog 2017-11-28 21:58:57 UTC (rev 225239)
+++ trunk/Tools/ChangeLog 2017-11-28 22:39:04 UTC (rev 225240)
@@ -1,3 +1,14 @@
+2017-11-28 Alexey Proskuryakov <[email protected]>
+
+ Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
+ https://bugs.webkit.org/show_bug.cgi?id=118505
+
+ Reviewed by Joseph Pecoraro.
+
+ * Scripts/valgrind/suppressions.txt:
+ * Scripts/webkitpy/port/leakdetector.py:
+ (LeakDetector._callstacks_to_exclude_from_leaks):
+
2017-11-28 Ms2ger <[email protected]>
Stop modifying self.expectations in TestExpectationLine.expected_behavior.
Modified: trunk/Tools/Scripts/valgrind/suppressions.txt (225239 => 225240)
--- trunk/Tools/Scripts/valgrind/suppressions.txt 2017-11-28 21:58:57 UTC (rev 225239)
+++ trunk/Tools/Scripts/valgrind/suppressions.txt 2017-11-28 22:39:04 UTC (rev 225240)
@@ -594,8 +594,6 @@
}
{
- # TextCodecICU::registerCodecs is leaking https://bugs.webkit.org/show_bug.cgi?id=118505
- WebCore::TextCodec::registerCodecs()
Memcheck:Leak
fun:malloc
fun:_ZN3WTF10fastMallocEm
Modified: trunk/Tools/Scripts/webkitpy/port/leakdetector.py (225239 => 225240)
--- trunk/Tools/Scripts/webkitpy/port/leakdetector.py 2017-11-28 21:58:57 UTC (rev 225239)
+++ trunk/Tools/Scripts/webkitpy/port/leakdetector.py 2017-11-28 22:39:04 UTC (rev 225240)
@@ -54,12 +54,9 @@
def _callstacks_to_exclude_from_leaks(self):
callstacks = [
- 'TextCodecICU::registerCodecs', # https://bugs.webkit.org/show_bug.cgi?id=118505
+ # List substrings here, e.g.
+ # 'TextCodecICU::registerCodecs', # https://bugs.webkit.org/show_bug.cgi?id=118505
]
- if self._port.operating_system == 'mac' and self._port.is_mavericks():
- callstacks += [
- 'AVAssetResourceLoader _poseAuthenticationChallengeWithKey:data:requestDictionary:fallbackHandler:', # <rdar://problem/19699887> leak in AVFoundation
- ]
return callstacks
def _leaks_args(self, pid):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
