Title: [225254] trunk/Source/WebCore
- Revision
- 225254
- Author
- [email protected]
- Date
- 2017-11-28 18:59:47 -0800 (Tue, 28 Nov 2017)
Log Message
REGRESSION (High Sierra): Layout Test fast/multicol/newmulticol/spanner2.html is a flaky image failure on WK1
https://bugs.webkit.org/show_bug.cgi?id=177826
<rdar://problem/34876498>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests, fixes some already-broken tests.
* platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::drawPDFPage):
Save and restore one more piece of context state that
PDFKit mutates while drawing.
Source/WebCore/PAL:
* pal/spi/cg/CoreGraphicsSPI.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (225253 => 225254)
--- trunk/Source/WebCore/ChangeLog 2017-11-29 02:23:38 UTC (rev 225253)
+++ trunk/Source/WebCore/ChangeLog 2017-11-29 02:59:47 UTC (rev 225254)
@@ -1,3 +1,18 @@
+2017-11-28 Tim Horton <[email protected]>
+
+ REGRESSION (High Sierra): Layout Test fast/multicol/newmulticol/spanner2.html is a flaky image failure on WK1
+ https://bugs.webkit.org/show_bug.cgi?id=177826
+ <rdar://problem/34876498>
+
+ Reviewed by Alexey Proskuryakov.
+
+ No new tests, fixes some already-broken tests.
+
+ * platform/graphics/mac/PDFDocumentImageMac.mm:
+ (WebCore::PDFDocumentImage::drawPDFPage):
+ Save and restore one more piece of context state that
+ PDFKit mutates while drawing.
+
2017-11-28 Wenson Hsieh <[email protected]>
Allow attachment elements with no appearance to defer rendering to child nodes
Modified: trunk/Source/WebCore/PAL/ChangeLog (225253 => 225254)
--- trunk/Source/WebCore/PAL/ChangeLog 2017-11-29 02:23:38 UTC (rev 225253)
+++ trunk/Source/WebCore/PAL/ChangeLog 2017-11-29 02:59:47 UTC (rev 225254)
@@ -1,3 +1,13 @@
+2017-11-28 Tim Horton <[email protected]>
+
+ REGRESSION (High Sierra): Layout Test fast/multicol/newmulticol/spanner2.html is a flaky image failure on WK1
+ https://bugs.webkit.org/show_bug.cgi?id=177826
+ <rdar://problem/34876498>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * pal/spi/cg/CoreGraphicsSPI.h:
+
2017-11-27 Tim Horton <[email protected]>
One too many zeroes in macOS version number in FeatureDefines
Modified: trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h (225253 => 225254)
--- trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h 2017-11-29 02:23:38 UTC (rev 225253)
+++ trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h 2017-11-29 02:59:47 UTC (rev 225254)
@@ -245,6 +245,7 @@
CGFontAntialiasingStyle CGContextGetFontAntialiasingStyle(CGContextRef);
void CGContextSetFontAntialiasingStyle(CGContextRef, CGFontAntialiasingStyle);
+bool CGContextGetAllowsFontSubpixelPositioning(CGContextRef);
bool CGContextDrawsWithCorrectShadowOffsets(CGContextRef);
CGPatternRef CGPatternCreateWithImage2(CGImageRef, CGAffineTransform, CGPatternTiling);
Modified: trunk/Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm (225253 => 225254)
--- trunk/Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm 2017-11-29 02:23:38 UTC (rev 225253)
+++ trunk/Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm 2017-11-29 02:59:47 UTC (rev 225254)
@@ -72,9 +72,10 @@
LocalCurrentGraphicsContext localCurrentContext(context);
// These states can be mutated by PDFKit but are not saved
- // on the context's state stack. (<rdar://problem/14951759>)
+ // on the context's state stack. (<rdar://problem/14951759&35738181>)
bool allowsSmoothing = CGContextGetAllowsFontSmoothing(context.platformContext());
bool allowsSubpixelQuantization = CGContextGetAllowsFontSubpixelQuantization(context.platformContext());
+ bool allowsSubpixelPositioning = CGContextGetAllowsFontSubpixelPositioning(context.platformContext());
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
@@ -83,6 +84,7 @@
CGContextSetAllowsFontSmoothing(context.platformContext(), allowsSmoothing);
CGContextSetAllowsFontSubpixelQuantization(context.platformContext(), allowsSubpixelQuantization);
+ CGContextSetAllowsFontSubpixelPositioning(context.platformContext(), allowsSubpixelPositioning);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
