Title: [225323] trunk/Source/WebCore
Revision
225323
Author
[email protected]
Date
2017-11-30 04:00:56 -0800 (Thu, 30 Nov 2017)

Log Message

[GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer usage
https://bugs.webkit.org/show_bug.cgi?id=179373

Reviewed by Xabier Rodriguez-Calvar.

This allows to build with WebAudio enabled even if video support is
disabled by guarding usage of HTMLMediaElement with ENABLE(VIDEO).

No new tests needed.

* page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::setGStreamerEnabled): Guard usage of HTMLMediaElement.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (225322 => 225323)


--- trunk/Source/WebCore/ChangeLog	2017-11-30 11:27:43 UTC (rev 225322)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 12:00:56 UTC (rev 225323)
@@ -1,3 +1,18 @@
+2017-11-30  Adrian Perez de Castro  <[email protected]>
+
+        [GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer usage
+        https://bugs.webkit.org/show_bug.cgi?id=179373
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        This allows to build with WebAudio enabled even if video support is
+        disabled by guarding usage of HTMLMediaElement with ENABLE(VIDEO).
+
+        No new tests needed.
+
+        * page/DeprecatedGlobalSettings.cpp:
+        (WebCore::DeprecatedGlobalSettings::setGStreamerEnabled): Guard usage of HTMLMediaElement.
+
 2017-11-29  Chris Dumez  <[email protected]>
 
         ServiceWorker WebProcess sometimes crashes in JSVMClientData::~JSVMClientData()

Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp (225322 => 225323)


--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2017-11-30 11:27:43 UTC (rev 225322)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2017-11-30 12:00:56 UTC (rev 225323)
@@ -141,7 +141,10 @@
         return;
 
     gGStreamerEnabled = enabled;
+
+#if ENABLE(VIDEO)
     HTMLMediaElement::resetMediaEngines();
+#endif
 }
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to