Title: [225347] trunk/Source/WebCore
- Revision
- 225347
- Author
- [email protected]
- Date
- 2017-11-30 13:42:29 -0800 (Thu, 30 Nov 2017)
Log Message
SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=180214
Reviewed by Brady Eidson.
SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted.
RefCounted is sufficient as there is no longer any multithreading on server side.
* workers/service/server/SWServerToContextConnection.h:
* workers/service/server/SWServerWorker.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (225346 => 225347)
--- trunk/Source/WebCore/ChangeLog 2017-11-30 21:41:59 UTC (rev 225346)
+++ trunk/Source/WebCore/ChangeLog 2017-11-30 21:42:29 UTC (rev 225347)
@@ -1,5 +1,18 @@
2017-11-30 Chris Dumez <[email protected]>
+ SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
+ https://bugs.webkit.org/show_bug.cgi?id=180214
+
+ Reviewed by Brady Eidson.
+
+ SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted.
+ RefCounted is sufficient as there is no longer any multithreading on server side.
+
+ * workers/service/server/SWServerToContextConnection.h:
+ * workers/service/server/SWServerWorker.h:
+
+2017-11-30 Chris Dumez <[email protected]>
+
ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
https://bugs.webkit.org/show_bug.cgi?id=180204
Modified: trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h (225346 => 225347)
--- trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h 2017-11-30 21:41:59 UTC (rev 225346)
+++ trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h 2017-11-30 21:42:29 UTC (rev 225347)
@@ -29,7 +29,7 @@
#include "ServiceWorkerIdentifier.h"
#include "ServiceWorkerTypes.h"
-#include <wtf/ThreadSafeRefCounted.h>
+#include <wtf/RefCounted.h>
namespace WebCore {
@@ -37,7 +37,7 @@
struct ServiceWorkerContextData;
struct ServiceWorkerJobDataIdentifier;
-class SWServerToContextConnection : public ThreadSafeRefCounted<SWServerToContextConnection> {
+class SWServerToContextConnection : public RefCounted<SWServerToContextConnection> {
public:
WEBCORE_EXPORT virtual ~SWServerToContextConnection();
Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.h (225346 => 225347)
--- trunk/Source/WebCore/workers/service/server/SWServerWorker.h 2017-11-30 21:41:59 UTC (rev 225346)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.h 2017-11-30 21:42:29 UTC (rev 225347)
@@ -32,7 +32,7 @@
#include "ServiceWorkerRegistrationKey.h"
#include "ServiceWorkerTypes.h"
#include "URL.h"
-#include <wtf/ThreadSafeRefCounted.h>
+#include <wtf/RefCounted.h>
namespace WebCore {
@@ -41,7 +41,7 @@
enum class WorkerType;
struct ServiceWorkerJobDataIdentifier;
-class SWServerWorker : public ThreadSafeRefCounted<SWServerWorker> {
+class SWServerWorker : public RefCounted<SWServerWorker> {
public:
template <typename... Args> static Ref<SWServerWorker> create(Args&&... args)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes