Title: [225365] trunk/Source/_javascript_Core
Revision
225365
Author
[email protected]
Date
2017-11-30 15:56:17 -0800 (Thu, 30 Nov 2017)

Log Message

[JSC] Use AllocatorIfExists for MaterializeNewObject
https://bugs.webkit.org/show_bug.cgi?id=180189

Reviewed by Filip Pizlo.

I don't think anyone guarantees this allocator exists at this phase.
And nullptr allocator just works here. We change AllocatorForMode
to AllocatorIfExists to accept nullptr for allocator.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225364 => 225365)


--- trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:50:15 UTC (rev 225364)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:56:17 UTC (rev 225365)
@@ -1,3 +1,17 @@
+2017-11-30  Yusuke Suzuki  <[email protected]>
+
+        [JSC] Use AllocatorIfExists for MaterializeNewObject
+        https://bugs.webkit.org/show_bug.cgi?id=180189
+
+        Reviewed by Filip Pizlo.
+
+        I don't think anyone guarantees this allocator exists at this phase.
+        And nullptr allocator just works here. We change AllocatorForMode
+        to AllocatorIfExists to accept nullptr for allocator.
+
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
+
 2017-11-30  Mark Lam  <[email protected]>
 
         Let's scramble MacroAssemblerCodePtr values.

Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (225364 => 225365)


--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-11-30 23:50:15 UTC (rev 225364)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-11-30 23:56:17 UTC (rev 225365)
@@ -9688,7 +9688,7 @@
             
             if (structure->outOfLineCapacity() || hasIndexedProperties(structure->indexingType())) {
                 size_t allocationSize = JSFinalObject::allocationSize(structure->inlineCapacity());
-                MarkedAllocator* cellAllocator = subspaceFor<JSFinalObject>(vm())->allocatorForNonVirtual(allocationSize, AllocatorForMode::MustAlreadyHaveAllocator);
+                MarkedAllocator* cellAllocator = subspaceFor<JSFinalObject>(vm())->allocatorForNonVirtual(allocationSize, AllocatorForMode::AllocatorIfExists);
 
                 bool hasIndexingHeader = hasIndexedProperties(structure->indexingType());
                 unsigned indexingHeaderSize = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to