Title: [225369] trunk/Source
- Revision
- 225369
- Author
- [email protected]
- Date
- 2017-11-30 16:18:08 -0800 (Thu, 30 Nov 2017)
Log Message
Fix some NSOperationQueue leaks
https://bugs.webkit.org/show_bug.cgi?id=180221
Patch by Joseph Pecoraro <[email protected]> on 2017-11-30
Reviewed by Wenson Hsieh.
Source/WebKit:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::performDragOperation):
Source/WebKitLegacy/mac:
* WebView/WebView.mm:
(-[WebView performDragOperation:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (225368 => 225369)
--- trunk/Source/WebKit/ChangeLog 2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKit/ChangeLog 2017-12-01 00:18:08 UTC (rev 225369)
@@ -1,3 +1,13 @@
+2017-11-30 Joseph Pecoraro <[email protected]>
+
+ Fix some NSOperationQueue leaks
+ https://bugs.webkit.org/show_bug.cgi?id=180221
+
+ Reviewed by Wenson Hsieh.
+
+ * UIProcess/Cocoa/WebViewImpl.mm:
+ (WebKit::WebViewImpl::performDragOperation):
+
2017-11-30 Brian Burg <[email protected]>
Web Automation: computeElementLayout does not correctly translate iframe client coordinates to main frame coordinates
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (225368 => 225369)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2017-12-01 00:18:08 UTC (rev 225369)
@@ -3723,7 +3723,8 @@
NSFilePromiseReceiver *item = draggingItem.item;
NSDictionary *options = @{ };
- [item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:[NSOperationQueue new] reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
+ RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]);
+ [item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:queue.get() reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
if (errorOrNil)
return;
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (225368 => 225369)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2017-12-01 00:18:08 UTC (rev 225369)
@@ -1,3 +1,13 @@
+2017-11-30 Joseph Pecoraro <[email protected]>
+
+ Fix some NSOperationQueue leaks
+ https://bugs.webkit.org/show_bug.cgi?id=180221
+
+ Reviewed by Wenson Hsieh.
+
+ * WebView/WebView.mm:
+ (-[WebView performDragOperation:]):
+
2017-11-30 Darin Adler <[email protected]>
[Mac] remove unneeded RetainPtr use introduced in r225142
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (225368 => 225369)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2017-12-01 00:18:08 UTC (rev 225369)
@@ -6729,7 +6729,8 @@
NSFilePromiseReceiver *item = draggingItem.item;
NSDictionary *options = @{ };
- [item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:[NSOperationQueue new] reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
+ RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]);
+ [item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:queue.get() reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
if (errorOrNil)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
