Title: [225406] trunk/Source/WebCore
Revision
225406
Author
[email protected]
Date
2017-12-01 12:36:50 -0800 (Fri, 01 Dec 2017)

Log Message

Many imported/w3c/web-platform-tests/service-workers/ test are failing together intermittently
https://bugs.webkit.org/show_bug.cgi?id=180227

Patch by Youenn Fablet <[email protected]> on 2017-12-01
Reviewed by Mark Lam.

No observable change.

* bindings/js/JSDOMPromise.cpp:
(WebCore::callFunction):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (225405 => 225406)


--- trunk/Source/WebCore/ChangeLog	2017-12-01 20:31:00 UTC (rev 225405)
+++ trunk/Source/WebCore/ChangeLog	2017-12-01 20:36:50 UTC (rev 225406)
@@ -1,3 +1,15 @@
+2017-12-01  Youenn Fablet  <[email protected]>
+
+        Many imported/w3c/web-platform-tests/service-workers/ test are failing together intermittently
+        https://bugs.webkit.org/show_bug.cgi?id=180227
+
+        Reviewed by Mark Lam.
+
+        No observable change.
+
+        * bindings/js/JSDOMPromise.cpp:
+        (WebCore::callFunction):
+
 2017-12-01  Brady Eidson  <[email protected]>
 
         Add Internals.terminateServiceWorker, and the ability to restart service workers for postMessage.

Modified: trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp (225405 => 225406)


--- trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp	2017-12-01 20:31:00 UTC (rev 225405)
+++ trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp	2017-12-01 20:36:50 UTC (rev 225406)
@@ -40,12 +40,14 @@
 
 static inline JSC::JSValue callFunction(JSC::ExecState& state, JSC::JSValue jsFunction, JSC::JSValue thisValue, const JSC::ArgList& arguments)
 {
-    auto scope = DECLARE_CATCH_SCOPE(state.vm());
+    auto scope = DECLARE_THROW_SCOPE(state.vm());
     JSC::CallData callData;
     auto callType = JSC::getCallData(jsFunction, callData);
     ASSERT(callType != JSC::CallType::None);
     auto result = call(&state, jsFunction, callType, callData, thisValue, arguments);
-    scope.assertNoException();
+
+    EXCEPTION_ASSERT_UNUSED(scope, !scope.exception() || isTerminatedExecutionException(state.vm(), scope.exception()));
+
     return result;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to