Title: [225458] trunk/Source/WebCore
- Revision
- 225458
- Author
- [email protected]
- Date
- 2017-12-03 01:07:25 -0800 (Sun, 03 Dec 2017)
Log Message
[GStreamer] GstCaps leaked in MediaPlayerPrivateGStreamer::createGSTPlayBin
https://bugs.webkit.org/show_bug.cgi?id=180311
Reviewed by Michael Catanzaro.
gst_caps_new_empty_simple() is passed directly to g_object_set(). The returned caps should be freed with
gst_caps_unref().
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (225457 => 225458)
--- trunk/Source/WebCore/ChangeLog 2017-12-03 05:32:33 UTC (rev 225457)
+++ trunk/Source/WebCore/ChangeLog 2017-12-03 09:07:25 UTC (rev 225458)
@@ -1,3 +1,16 @@
+2017-12-03 Carlos Garcia Campos <[email protected]>
+
+ [GStreamer] GstCaps leaked in MediaPlayerPrivateGStreamer::createGSTPlayBin
+ https://bugs.webkit.org/show_bug.cgi?id=180311
+
+ Reviewed by Michael Catanzaro.
+
+ gst_caps_new_empty_simple() is passed directly to g_object_set(). The returned caps should be freed with
+ gst_caps_unref().
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+
2017-12-02 Youenn Fablet <[email protected]>
Move registration activation and clearing from SWServerJobQueue to SWServerRegistration
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (225457 => 225458)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2017-12-03 05:32:33 UTC (rev 225457)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2017-12-03 09:07:25 UTC (rev 225458)
@@ -2113,7 +2113,8 @@
m_textAppSinkPad = adoptGRef(gst_element_get_static_pad(m_textAppSink.get(), "sink"));
ASSERT(m_textAppSinkPad);
- g_object_set(m_textAppSink.get(), "emit-signals", true, "enable-last-sample", false, "caps", gst_caps_new_empty_simple("text/vtt"), nullptr);
+ GRefPtr<GstCaps> textCaps = adoptGRef(gst_caps_new_empty_simple("text/vtt"));
+ g_object_set(m_textAppSink.get(), "emit-signals", TRUE, "enable-last-sample", FALSE, "caps", textCaps.get(), nullptr);
g_signal_connect_swapped(m_textAppSink.get(), "new-sample", G_CALLBACK(newTextSampleCallback), this);
g_object_set(m_pipeline.get(), "text-sink", m_textAppSink.get(), nullptr);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
