Title: [225466] trunk/Tools
- Revision
- 225466
- Author
- [email protected]
- Date
- 2017-12-03 16:28:12 -0800 (Sun, 03 Dec 2017)
Log Message
webkitpy EWS keeps retrying a failing patch
https://bugs.webkit.org/show_bug.cgi?id=180302
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test_patch): Instead of returning false, call report_failure()
which raises an exception, this exception is catched by earlywarningsystem.py and
it posts a comment on bugzilla. Returning false simply unlocks the patch and returns
it to the queue.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (225465 => 225466)
--- trunk/Tools/ChangeLog 2017-12-03 23:08:30 UTC (rev 225465)
+++ trunk/Tools/ChangeLog 2017-12-04 00:28:12 UTC (rev 225466)
@@ -1,3 +1,16 @@
+2017-12-03 Aakash Jain <[email protected]>
+
+ webkitpy EWS keeps retrying a failing patch
+ https://bugs.webkit.org/show_bug.cgi?id=180302
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/tool/bot/patchanalysistask.py:
+ (PatchAnalysisTask._test_patch): Instead of returning false, call report_failure()
+ which raises an exception, this exception is catched by earlywarningsystem.py and
+ it posts a comment on bugzilla. Returning false simply unlocks the patch and returns
+ it to the queue.
+
2017-12-03 Darin Adler <[email protected]>
Add WTF::Hasher, an easier to use replacement for WTF::IntegerHasher
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py (225465 => 225466)
--- trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py 2017-12-03 23:08:30 UTC (rev 225465)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py 2017-12-04 00:28:12 UTC (rev 225466)
@@ -369,7 +369,7 @@
elif hasattr(self._delegate, 'group') and self._delegate.group() == "bindings":
return self._retry_bindings_tests()
elif hasattr(self._delegate, 'group') and self._delegate.group() == "webkitpy":
- return False
+ return self.report_failure()
else:
return self._retry_layout_tests()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
