Title: [225496] trunk/Tools
- Revision
- 225496
- Author
- commit-qu...@webkit.org
- Date
- 2017-12-04 14:51:13 -0800 (Mon, 04 Dec 2017)
Log Message
Exclude some more leak callstacks
https://bugs.webkit.org/show_bug.cgi?id=180379
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-12-04
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/port/leakdetector.py:
(LeakDetector._types_to_exclude_from_leaks):
(LeakDetector._callstacks_to_exclude_from_leaks):
(LeakDetector._leaks_args):
(LeakDetector._types_to_exlude_from_leaks): Deleted.
* Scripts/webkitpy/port/leakdetector_unittest.py:
(LeakDetectorTest.test_leaks_args):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (225495 => 225496)
--- trunk/Tools/ChangeLog 2017-12-04 22:49:25 UTC (rev 225495)
+++ trunk/Tools/ChangeLog 2017-12-04 22:51:13 UTC (rev 225496)
@@ -1,3 +1,18 @@
+2017-12-04 Joseph Pecoraro <pecor...@apple.com>
+
+ Exclude some more leak callstacks
+ https://bugs.webkit.org/show_bug.cgi?id=180379
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/port/leakdetector.py:
+ (LeakDetector._types_to_exclude_from_leaks):
+ (LeakDetector._callstacks_to_exclude_from_leaks):
+ (LeakDetector._leaks_args):
+ (LeakDetector._types_to_exlude_from_leaks): Deleted.
+ * Scripts/webkitpy/port/leakdetector_unittest.py:
+ (LeakDetectorTest.test_leaks_args):
+
2017-12-03 Yusuke Suzuki <utatane....@gmail.com>
WTF shouldn't have both Thread and ThreadIdentifier
Modified: trunk/Tools/Scripts/webkitpy/port/leakdetector.py (225495 => 225496)
--- trunk/Tools/Scripts/webkitpy/port/leakdetector.py 2017-12-04 22:49:25 UTC (rev 225495)
+++ trunk/Tools/Scripts/webkitpy/port/leakdetector.py 2017-12-04 22:51:13 UTC (rev 225496)
@@ -48,7 +48,7 @@
# This allows us ignore known leaks and only be alerted when new leaks occur. Some leaks are in the old
# versions of the system frameworks that are being used by the leaks bots. Even though a leak has been
# fixed, it will be listed here until the bot has been updated with the newer frameworks.
- def _types_to_exlude_from_leaks(self):
+ def _types_to_exclude_from_leaks(self):
# Currently we don't have any type excludes from OS leaks, but we will likely again in the future.
return []
@@ -55,6 +55,9 @@
def _callstacks_to_exclude_from_leaks(self):
callstacks = [
'WTF::BitVector::OutOfLineBits::create', # https://bugs.webkit.org/show_bug.cgi?id=121662
+ 'WebCore::createPrivateStorageSession', # <rdar://problem/35189565>
+ 'CIDeviceManagerStartMonitoring', # <rdar://problem/35711052>
+ 'NSSpellChecker init', # <rdar://problem/35434615>
]
return callstacks
@@ -62,7 +65,7 @@
leaks_args = []
for callstack in self._callstacks_to_exclude_from_leaks():
leaks_args += ['--exclude-callstack=%s' % callstack]
- for excluded_type in self._types_to_exlude_from_leaks():
+ for excluded_type in self._types_to_exclude_from_leaks():
leaks_args += ['--exclude-type=%s' % excluded_type]
leaks_args.append(pid)
return leaks_args
Modified: trunk/Tools/Scripts/webkitpy/port/leakdetector_unittest.py (225495 => 225496)
--- trunk/Tools/Scripts/webkitpy/port/leakdetector_unittest.py 2017-12-04 22:49:25 UTC (rev 225495)
+++ trunk/Tools/Scripts/webkitpy/port/leakdetector_unittest.py 2017-12-04 22:51:13 UTC (rev 225496)
@@ -49,7 +49,7 @@
def test_leaks_args(self):
detector = self._make_detector()
detector._callstacks_to_exclude_from_leaks = lambda: ['foo bar', 'BAZ']
- detector._types_to_exlude_from_leaks = lambda: ['abcdefg', 'hi jklmno']
+ detector._types_to_exclude_from_leaks = lambda: ['abcdefg', 'hi jklmno']
expected_args = ['--exclude-callstack=foo bar', '--exclude-callstack=BAZ', '--exclude-type=abcdefg', '--exclude-type=hi jklmno', 1234]
self.assertEqual(detector._leaks_args(1234), expected_args)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
