Title: [225549] trunk
Revision
225549
Author
[email protected]
Date
2017-12-05 14:46:08 -0800 (Tue, 05 Dec 2017)

Log Message

XMLHttpRequest should not be exposed to service workers
https://bugs.webkit.org/show_bug.cgi?id=180446

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that has one more check passing.

* web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:

Source/WebCore:

Stop exposing XMLHttpRequest to service workers, as per:
- https://xhr.spec.whatwg.org/#interface-xmlhttprequest

* xml/XMLHttpRequest.idl:

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (225548 => 225549)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-12-05 22:34:38 UTC (rev 225548)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-12-05 22:46:08 UTC (rev 225549)
@@ -1,3 +1,14 @@
+2017-12-05  Chris Dumez  <[email protected]>
+
+        XMLHttpRequest should not be exposed to service workers
+        https://bugs.webkit.org/show_bug.cgi?id=180446
+
+        Reviewed by Youenn Fablet.
+
+        Rebaseline WPT test that has one more check passing.
+
+        * web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
+
 2017-12-05  Youenn Fablet  <[email protected]>
 
         Implement https://w3c.github.io/ServiceWorker/#clients-claim

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt (225548 => 225549)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt	2017-12-05 22:34:38 UTC (rev 225548)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt	2017-12-05 22:46:08 UTC (rev 225549)
@@ -4,7 +4,7 @@
 PASS Interfaces and attributes in ServiceWorkerGlobalScope 
 TIMEOUT test setup (cache creation) Test timed out
 FAIL Event constructors assert_equals: Default FetchEvent.clientId should be null expected (object) null but got (string) ""
-FAIL xhr is not exposed assert_false: expected false got true
+PASS xhr is not exposed 
 PASS ServiceWorkerGlobalScope interface: existence and properties of interface object 
 PASS ServiceWorkerGlobalScope interface object length 
 PASS ServiceWorkerGlobalScope interface object name 

Modified: trunk/Source/WebCore/ChangeLog (225548 => 225549)


--- trunk/Source/WebCore/ChangeLog	2017-12-05 22:34:38 UTC (rev 225548)
+++ trunk/Source/WebCore/ChangeLog	2017-12-05 22:46:08 UTC (rev 225549)
@@ -1,3 +1,15 @@
+2017-12-05  Chris Dumez  <[email protected]>
+
+        XMLHttpRequest should not be exposed to service workers
+        https://bugs.webkit.org/show_bug.cgi?id=180446
+
+        Reviewed by Youenn Fablet.
+
+        Stop exposing XMLHttpRequest to service workers, as per:
+        - https://xhr.spec.whatwg.org/#interface-xmlhttprequest
+
+        * xml/XMLHttpRequest.idl:
+
 2017-12-05  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: content views for resources loaded through XHR do not reflect declared mime-type

Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (225548 => 225549)


--- trunk/Source/WebCore/xml/XMLHttpRequest.idl	2017-12-05 22:34:38 UTC (rev 225548)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl	2017-12-05 22:46:08 UTC (rev 225549)
@@ -43,7 +43,7 @@
     Constructor,
     ConstructorCallWith=ScriptExecutionContext,
     ExportMacro=WEBCORE_EXPORT,
-    Exposed=(Window,Worker),
+    Exposed=(Window,DedicatedWorker),
     JSCustomMarkFunction,
     JSGenerateToJSObject,
     JSGenerateToNativeObject,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to