Title: [225552] trunk
Revision
225552
Author
[email protected]
Date
2017-12-05 15:01:07 -0800 (Tue, 05 Dec 2017)

Log Message

Make WebKit build for ARM64_32
https://bugs.webkit.org/show_bug.cgi?id=180447

Reviewed by Mark Lam.

Source/WebCore:

No new test as this isn't a change to functionality.

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::multiply): Fallback to the C++ version for
ARM64_32.

Source/WTF:

Add the 'w' (32bit) pointer qualifier for ARM64_32 pointers in inline assembly.

* wtf/darwin/WeakLinking.h:
(WTF::isNullFunctionPointer):

Tools:

Add an instance of the _TestWTFAlwaysMissing for arm64_32 architecture.

* TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (225551 => 225552)


--- trunk/Source/WTF/ChangeLog	2017-12-05 22:50:47 UTC (rev 225551)
+++ trunk/Source/WTF/ChangeLog	2017-12-05 23:01:07 UTC (rev 225552)
@@ -1,3 +1,15 @@
+2017-12-05  Michael Saboff  <[email protected]>
+
+        Make WebKit build for ARM64_32
+        https://bugs.webkit.org/show_bug.cgi?id=180447
+
+        Reviewed by Mark Lam.
+
+        Add the 'w' (32bit) pointer qualifier for ARM64_32 pointers in inline assembly.
+
+        * wtf/darwin/WeakLinking.h:
+        (WTF::isNullFunctionPointer):
+
 2017-12-05  Filip Pizlo  <[email protected]>
 
         bmalloc IsoHeap needs to allow a thread to deallocate some size for the first time

Modified: trunk/Source/WTF/wtf/darwin/WeakLinking.h (225551 => 225552)


--- trunk/Source/WTF/wtf/darwin/WeakLinking.h	2017-12-05 22:50:47 UTC (rev 225551)
+++ trunk/Source/WTF/wtf/darwin/WeakLinking.h	2017-12-05 23:01:07 UTC (rev 225552)
@@ -37,7 +37,11 @@
     // null. When weak-linking a library, function pointers can be null. We use non-C code to
     // prevent the C compiler from using the definition to optimize out the null check.
     asm(
+#if CPU(ARM64) && defined(__ILP32__)
+        "mov %w1, %w0"
+#else
         "mov %1, %0"
+#endif
         : "=r" (result)
         : "r" (functionPointer)
     );

Modified: trunk/Source/WebCore/ChangeLog (225551 => 225552)


--- trunk/Source/WebCore/ChangeLog	2017-12-05 22:50:47 UTC (rev 225551)
+++ trunk/Source/WebCore/ChangeLog	2017-12-05 23:01:07 UTC (rev 225552)
@@ -1,3 +1,16 @@
+2017-12-05  Michael Saboff  <[email protected]>
+
+        Make WebKit build for ARM64_32
+        https://bugs.webkit.org/show_bug.cgi?id=180447
+
+        Reviewed by Mark Lam.
+
+        No new test as this isn't a change to functionality.
+
+        * platform/graphics/transforms/TransformationMatrix.cpp:
+        (WebCore::TransformationMatrix::multiply): Fallback to the C++ version for
+        ARM64_32.
+
 2017-12-05  Chris Dumez  <[email protected]>
 
         XMLHttpRequest should not be exposed to service workers

Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp (225551 => 225552)


--- trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp	2017-12-05 22:50:47 UTC (rev 225551)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp	2017-12-05 23:01:07 UTC (rev 225552)
@@ -1048,7 +1048,7 @@
 // this = mat * this.
 TransformationMatrix& TransformationMatrix::multiply(const TransformationMatrix& mat)
 {
-#if CPU(ARM64)
+#if CPU(ARM64) && defined(_LP64)
     double* leftMatrix = &(m_matrix[0][0]);
     const double* rightMatrix = &(mat.m_matrix[0][0]);
     asm volatile (

Modified: trunk/Tools/ChangeLog (225551 => 225552)


--- trunk/Tools/ChangeLog	2017-12-05 22:50:47 UTC (rev 225551)
+++ trunk/Tools/ChangeLog	2017-12-05 23:01:07 UTC (rev 225552)
@@ -1,3 +1,14 @@
+2017-12-05  Michael Saboff  <[email protected]>
+
+        Make WebKit build for ARM64_32
+        https://bugs.webkit.org/show_bug.cgi?id=180447
+
+        Reviewed by Mark Lam.
+
+        Add an instance of the _TestWTFAlwaysMissing for arm64_32 architecture.
+
+        * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
+
 2017-12-05  Aakash Jain  <[email protected]>
 
         [build.webkit.org] Rename mastercfg_unittest to steps_unittest

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd (225551 => 225552)


--- trunk/Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd	2017-12-05 22:50:47 UTC (rev 225551)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd	2017-12-05 23:01:07 UTC (rev 225552)
@@ -1,10 +1,10 @@
 --- !tapi-tbd-v2
-archs: [ i386, x86_64, armv7, armv7s, arm64 ]
-uuids: [ 'i386: 6EA81A0A-D83F-4081-B3EA-90419C1573BA87', 'x86_64: 28E81E11-2794-4192-A46A-06C73C9BAFB9', 'armv7: 00C67397-F7A2-431A-9F27-D4F61106FC1F', 'armv7s: F9C172FC-A112-488C-889B-B70FA20AE827', 'arm64: 3FDB12FB-0BF2-405C-B21A-2D3D2D18EB5F' ]
+archs: [ i386, x86_64, armv7, armv7s, arm64, arm64_32 ]
+uuids: [ 'i386: 6EA81A0A-D83F-4081-B3EA-90419C1573BA87', 'x86_64: 28E81E11-2794-4192-A46A-06C73C9BAFB9', 'armv7: 00C67397-F7A2-431A-9F27-D4F61106FC1F', 'armv7s: F9C172FC-A112-488C-889B-B70FA20AE827', 'arm64: 3FDB12FB-0BF2-405C-B21A-2D3D2D18EB5F', 'arm64_32: 7AACF92F-A11C-4015-9434-365CE3DC5F9E' ]
 platform: ios
 install-name: /usr/local/lib/libTestWTFAlwaysMissing.dylib
 objc-constraint: none
 exports:
-  - archs: [ i386, x86_64, armv7, armv7s, arm64 ]
+  - archs: [ i386, x86_64, armv7, armv7s, arm64, arm64_32 ]
     symbols: [ _TestWTFAlwaysMissing ]
 ...
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to