Title: [225584] trunk
- Revision
- 225584
- Author
- [email protected]
- Date
- 2017-12-06 11:43:31 -0800 (Wed, 06 Dec 2017)
Log Message
Some iOS tests failing after ANGLE update
https://bugs.webkit.org/show_bug.cgi?id=180487
<rdar://problem/35885969>
Reviewed by Antoine Quint.
Source/ThirdParty/ANGLE:
The iOS OpenGL compiler doesn't like function declarations with
nameless array parameters. See:
<rdar://problem/35885989> Nameless array parameters in function declaration cause compiler error
While that is being fixed, tell ANGLE's translator to not cull
the names from parameters. This is not a bug in ANGLE, so we won't
fix it upstream at the moment.
* src/compiler/translator/ParseContext.cpp:
(sh::TParseContext::addFunctionPrototypeDeclaration):
LayoutTests:
Unskip some WebGL tests.
* platform/ios/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (225583 => 225584)
--- trunk/LayoutTests/ChangeLog 2017-12-06 19:41:01 UTC (rev 225583)
+++ trunk/LayoutTests/ChangeLog 2017-12-06 19:43:31 UTC (rev 225584)
@@ -1,3 +1,15 @@
+2017-12-06 Dean Jackson <[email protected]>
+
+ Some iOS tests failing after ANGLE update
+ https://bugs.webkit.org/show_bug.cgi?id=180487
+ <rdar://problem/35885969>
+
+ Reviewed by Antoine Quint.
+
+ Unskip some WebGL tests.
+
+ * platform/ios/TestExpectations:
+
2017-12-06 John Wilander <[email protected]>
Storage Access API: Make document.hasStorageAccess a function and always allow access for same-origin iframes
Modified: trunk/LayoutTests/platform/ios/TestExpectations (225583 => 225584)
--- trunk/LayoutTests/platform/ios/TestExpectations 2017-12-06 19:41:01 UTC (rev 225583)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2017-12-06 19:43:31 UTC (rev 225584)
@@ -2957,7 +2957,6 @@
webgl/1.0.3/conformance/glsl/misc/shader-struct-scope.html [ Failure ]
webgl/1.0.3/conformance/glsl/misc/shaders-with-invariance.html [ Failure ]
webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts.html [ Failure ]
-webgl/1.0.3/conformance/glsl/misc/struct-nesting-of-variable-names.html [ Failure ]
webgl/1.0.3/conformance/renderbuffers/feedback-loop.html [ Failure ]
webgl/1.0.3/conformance/rendering/point-no-attributes.html [ Failure ]
webgl/1.0.3/conformance/textures/texture-copying-feedback-loops.html [ Failure ]
@@ -3080,7 +3079,6 @@
webgl/1.0.2/conformance/ogles/GL/log2/log2_001_to_008.html [ Skip ]
# <rdar://problem/33135669>
-webgl/1.0.2/conformance/textures/gl-teximage.html [ Failure ]
fast/canvas/webgl/gl-teximage.html [ Failure ]
# <rdar://problem/30517283>
@@ -3300,8 +3298,5 @@
# <rdar://problem/33731086>
media/modern-media-controls/time-labels-support/elapsed-time.html [ Skip ]
-# Skip WebGL while the ANGLE update has caused many failures
-webgl [ Skip ]
-
# Requries AVFoundation support <rdar://problem/34502208>
http/tests/images/image-supports-video.html
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (225583 => 225584)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2017-12-06 19:41:01 UTC (rev 225583)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2017-12-06 19:43:31 UTC (rev 225584)
@@ -1,3 +1,22 @@
+2017-12-06 Dean Jackson <[email protected]>
+
+ Some iOS tests failing after ANGLE update
+ https://bugs.webkit.org/show_bug.cgi?id=180487
+ <rdar://problem/35885969>
+
+ Reviewed by Antoine Quint.
+
+ The iOS OpenGL compiler doesn't like function declarations with
+ nameless array parameters. See:
+ <rdar://problem/35885989> Nameless array parameters in function declaration cause compiler error
+
+ While that is being fixed, tell ANGLE's translator to not cull
+ the names from parameters. This is not a bug in ANGLE, so we won't
+ fix it upstream at the moment.
+
+ * src/compiler/translator/ParseContext.cpp:
+ (sh::TParseContext::addFunctionPrototypeDeclaration):
+
2017-12-01 Michael Catanzaro <[email protected]>
Unreviewed, fix byte order macros and address new -Wunknown-pragmas warnings
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp (225583 => 225584)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp 2017-12-06 19:41:01 UTC (rev 225583)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp 2017-12-06 19:43:31 UTC (rev 225584)
@@ -3240,8 +3240,11 @@
}
function->setHasPrototypeDeclaration();
+ // WebKit note: We currently pass true instead of false for the last parameter
+ // here because some compilers have an issue with nameless parameters in function
+ // declarations.
TIntermFunctionPrototype *prototype =
- createPrototypeNodeFromFunction(*function, location, false);
+ createPrototypeNodeFromFunction(*function, location, true);
symbolTable.pop();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
