Title: [225676] trunk/Source/WebKit
Revision
225676
Author
mcatanz...@igalia.com
Date
2017-12-08 08:28:48 -0800 (Fri, 08 Dec 2017)

Log Message

[GTK] WebInspectorProxyClient needs a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=180533

Reviewed by Carlos Garcia Campos.

Otherwise the derived class portion of the object, WebKitInspectorClient, is not destroyed.

* UIProcess/gtk/WebInspectorProxyClient.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (225675 => 225676)


--- trunk/Source/WebKit/ChangeLog	2017-12-08 15:00:27 UTC (rev 225675)
+++ trunk/Source/WebKit/ChangeLog	2017-12-08 16:28:48 UTC (rev 225676)
@@ -1,3 +1,14 @@
+2017-12-08  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        [GTK] WebInspectorProxyClient needs a virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=180533
+
+        Reviewed by Carlos Garcia Campos.
+
+        Otherwise the derived class portion of the object, WebKitInspectorClient, is not destroyed.
+
+        * UIProcess/gtk/WebInspectorProxyClient.h:
+
 2017-12-07  Yousuke Kimoto  <yousuke.kim...@sony.com>
 
         [WinCairo] Fix ResourceError handling in ArgumentCoder for wincairo webkit

Modified: trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyClient.h (225675 => 225676)


--- trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyClient.h	2017-12-08 15:00:27 UTC (rev 225675)
+++ trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyClient.h	2017-12-08 16:28:48 UTC (rev 225676)
@@ -33,6 +33,7 @@
 
 class WebInspectorProxyClient {
 public:
+    virtual ~WebInspectorProxyClient() = default;
     virtual bool openWindow(WebInspectorProxy&) = 0;
     virtual void didClose(WebInspectorProxy&) = 0;
     virtual bool bringToFront(WebInspectorProxy&) = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to