Title: [225700] trunk/Source/WebKit
- Revision
- 225700
- Author
- [email protected]
- Date
- 2017-12-08 14:23:22 -0800 (Fri, 08 Dec 2017)
Log Message
Remove unused code in WebPageGroup
https://bugs.webkit.org/show_bug.cgi?id=180604
Reviewed by Youenn Fablet.
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::userContentController):
(WebKit::WebPageGroup::createNonNull): Deleted.
(WebKit::WebPageGroup::preferencesDidChange): Deleted.
* UIProcess/WebPageGroup.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (225699 => 225700)
--- trunk/Source/WebKit/ChangeLog 2017-12-08 22:05:07 UTC (rev 225699)
+++ trunk/Source/WebKit/ChangeLog 2017-12-08 22:23:22 UTC (rev 225700)
@@ -1,5 +1,20 @@
2017-12-08 Alex Christensen <[email protected]>
+ Remove unused code in WebPageGroup
+ https://bugs.webkit.org/show_bug.cgi?id=180604
+
+ Reviewed by Youenn Fablet.
+
+ * UIProcess/WebPageGroup.cpp:
+ (WebKit::WebPageGroup::userContentController):
+ (WebKit::WebPageGroup::createNonNull): Deleted.
+ (WebKit::WebPageGroup::preferencesDidChange): Deleted.
+ * UIProcess/WebPageGroup.h:
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::WebProcessPool):
+
+2017-12-08 Alex Christensen <[email protected]>
+
Modernize APIWebsiteDataStore.h and WebProcessPool.h
https://bugs.webkit.org/show_bug.cgi?id=180588
Modified: trunk/Source/WebKit/UIProcess/WebPageGroup.cpp (225699 => 225700)
--- trunk/Source/WebKit/UIProcess/WebPageGroup.cpp 2017-12-08 22:05:07 UTC (rev 225699)
+++ trunk/Source/WebKit/UIProcess/WebPageGroup.cpp 2017-12-08 22:23:22 UTC (rev 225700)
@@ -59,11 +59,6 @@
return adoptRef(*new WebPageGroup(identifier, visibleToInjectedBundle, visibleToHistoryClient));
}
-Ref<WebPageGroup> WebPageGroup::createNonNull(const String& identifier, bool visibleToInjectedBundle, bool visibleToHistoryClient)
-{
- return adoptRef(*new WebPageGroup(identifier, visibleToInjectedBundle, visibleToHistoryClient));
-}
-
WebPageGroup* WebPageGroup::get(uint64_t pageGroupID)
{
return webPageGroupMap().get(pageGroupID);
@@ -129,17 +124,9 @@
return *m_preferences;
}
-void WebPageGroup::preferencesDidChange()
-{
- for (HashSet<WebPageProxy*>::iterator it = m_pages.begin(), end = m_pages.end(); it != end; ++it) {
- WebPageProxy* page = *it;
- page->preferencesDidChange();
- }
-}
-
WebUserContentControllerProxy& WebPageGroup::userContentController()
{
- return *m_userContentController;
+ return m_userContentController;
}
} // namespace WebKit
Modified: trunk/Source/WebKit/UIProcess/WebPageGroup.h (225699 => 225700)
--- trunk/Source/WebKit/UIProcess/WebPageGroup.h 2017-12-08 22:05:07 UTC (rev 225699)
+++ trunk/Source/WebKit/UIProcess/WebPageGroup.h 2017-12-08 22:23:22 UTC (rev 225700)
@@ -23,8 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebPageGroup_h
-#define WebPageGroup_h
+#pragma once
#include "APIObject.h"
#include "WebPageGroupData.h"
@@ -44,7 +43,7 @@
public:
WebPageGroup(const String& identifier = String(), bool visibleToInjectedBundle = true, bool visibleToHistoryClient = true);
static Ref<WebPageGroup> create(const String& identifier = String(), bool visibleToInjectedBundle = true, bool visibleToHistoryClient = true);
- static Ref<WebPageGroup> createNonNull(const String& identifier = String(), bool visibleToInjectedBundle = true, bool visibleToHistoryClient = true);
+
static WebPageGroup* get(uint64_t pageGroupID);
virtual ~WebPageGroup();
@@ -58,7 +57,6 @@
void setPreferences(WebPreferences*);
WebPreferences& preferences() const;
- void preferencesDidChange();
WebUserContentControllerProxy& userContentController();
@@ -65,10 +63,8 @@
private:
WebPageGroupData m_data;
RefPtr<WebPreferences> m_preferences;
- RefPtr<WebUserContentControllerProxy> m_userContentController;
+ Ref<WebUserContentControllerProxy> m_userContentController;
HashSet<WebPageProxy*> m_pages;
};
} // namespace WebKit
-
-#endif // WebPageGroup_h
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (225699 => 225700)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-12-08 22:05:07 UTC (rev 225699)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-12-08 22:23:22 UTC (rev 225700)
@@ -216,7 +216,7 @@
WebProcessPool::WebProcessPool(API::ProcessPoolConfiguration& configuration)
: m_configuration(configuration.copy())
- , m_defaultPageGroup(WebPageGroup::createNonNull())
+ , m_defaultPageGroup(WebPageGroup::create())
, m_injectedBundleClient(std::make_unique<API::InjectedBundleClient>())
, m_automationClient(std::make_unique<API::AutomationClient>())
, m_downloadClient(std::make_unique<API::DownloadClient>())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
