Title: [225747] trunk
Revision
225747
Author
[email protected]
Date
2017-12-11 10:09:32 -0800 (Mon, 11 Dec 2017)

Log Message

Turn on ENABLE_APPLICATION_MANIFEST
https://bugs.webkit.org/show_bug.cgi?id=180562
rdar://problem/35924737

Patch by David Quesada <[email protected]> on 2017-12-11
Reviewed by Geoffrey Garen.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient):
* loader/cached/CachedResourceRequest.cpp:
    Add a missing #include that was implicitly added in the unified source when
    the feature is disabled.

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (225746 => 225747)


--- trunk/LayoutTests/ChangeLog	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/LayoutTests/ChangeLog	2017-12-11 18:09:32 UTC (rev 225747)
@@ -1,3 +1,14 @@
+2017-12-11  David Quesada  <[email protected]>
+
+        Turn on ENABLE_APPLICATION_MANIFEST
+        https://bugs.webkit.org/show_bug.cgi?id=180562
+        rdar://problem/35924737
+
+        Reviewed by Geoffrey Garen.
+
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+
 2017-12-11  Dean Jackson  <[email protected]>
 
         Add a runtime feature flag for ImageBitmap and OffscreenCanvas

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (225746 => 225747)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-12-11 18:09:32 UTC (rev 225747)
@@ -61,6 +61,10 @@
 
 webkit.org/b/170713 imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-022.html [ ImageOnlyFailure ]
 
+http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Pass ]
+http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Pass ]
+applicationmanifest/ [ Pass ]
+
 #//////////////////////////////////////////////////////////////////////////////////////////
 # End platform-specific directories.
 #//////////////////////////////////////////////////////////////////////////////////////////

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (225746 => 225747)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-12-11 18:09:32 UTC (rev 225747)
@@ -58,6 +58,10 @@
 imported/w3c/web-platform-tests/payment-request/user-abort-algorithm-manual.https.html [ Skip ]
 imported/w3c/web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html [ Skip ]
 
+http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Pass ]
+http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Pass ]
+applicationmanifest/ [ Pass ]
+
 #//////////////////////////////////////////////////////////////////////////////////////////
 # End platform-specific directories.
 #//////////////////////////////////////////////////////////////////////////////////////////

Modified: trunk/Source/_javascript_Core/ChangeLog (225746 => 225747)


--- trunk/Source/_javascript_Core/ChangeLog	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-11 18:09:32 UTC (rev 225747)
@@ -1,3 +1,13 @@
+2017-12-11  David Quesada  <[email protected]>
+
+        Turn on ENABLE_APPLICATION_MANIFEST
+        https://bugs.webkit.org/show_bug.cgi?id=180562
+        rdar://problem/35924737
+
+        Reviewed by Geoffrey Garen.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-10  Filip Pizlo  <[email protected]>
 
         Harden a few assertions in GC sweep

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (225746 => 225747)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-12-11 18:09:32 UTC (rev 225747)
@@ -66,7 +66,7 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
-ENABLE_APPLICATION_MANIFEST = ;
+ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
 ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING;

Modified: trunk/Source/WebCore/ChangeLog (225746 => 225747)


--- trunk/Source/WebCore/ChangeLog	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebCore/ChangeLog	2017-12-11 18:09:32 UTC (rev 225747)
@@ -1,3 +1,18 @@
+2017-12-11  David Quesada  <[email protected]>
+
+        Turn on ENABLE_APPLICATION_MANIFEST
+        https://bugs.webkit.org/show_bug.cgi?id=180562
+        rdar://problem/35924737
+
+        Reviewed by Geoffrey Garen.
+
+        * Configurations/FeatureDefines.xcconfig:
+        * loader/LinkLoader.cpp:
+        (WebCore::createLinkPreloadResourceClient):
+        * loader/cached/CachedResourceRequest.cpp:
+            Add a missing #include that was implicitly added in the unified source when
+            the feature is disabled.
+
 2017-12-11  Dean Jackson  <[email protected]>
 
         Add a runtime feature flag for ImageBitmap and OffscreenCanvas

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (225746 => 225747)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-12-11 18:09:32 UTC (rev 225747)
@@ -66,7 +66,7 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
-ENABLE_APPLICATION_MANIFEST = ;
+ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
 ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING;

Modified: trunk/Source/WebCore/PAL/ChangeLog (225746 => 225747)


--- trunk/Source/WebCore/PAL/ChangeLog	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-12-11 18:09:32 UTC (rev 225747)
@@ -1,3 +1,13 @@
+2017-12-11  David Quesada  <[email protected]>
+
+        Turn on ENABLE_APPLICATION_MANIFEST
+        https://bugs.webkit.org/show_bug.cgi?id=180562
+        rdar://problem/35924737
+
+        Reviewed by Geoffrey Garen.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-08  Konstantin Tokarev  <[email protected]>
 
         [python] Replace print operator with print() function for python3 compatibility

Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (225746 => 225747)


--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-12-11 18:09:32 UTC (rev 225747)
@@ -66,7 +66,7 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
-ENABLE_APPLICATION_MANIFEST = ;
+ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
 ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING;

Modified: trunk/Source/WebCore/loader/LinkLoader.cpp (225746 => 225747)


--- trunk/Source/WebCore/loader/LinkLoader.cpp	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebCore/loader/LinkLoader.cpp	2017-12-11 18:09:32 UTC (rev 225747)
@@ -169,13 +169,11 @@
     case CachedResource::LinkSubresource:
     case CachedResource::LinkPrefetch:
 #endif
-        // None of these values is currently supported as an `as` value.
-        ASSERT_NOT_REACHED();
 #if ENABLE(APPLICATION_MANIFEST)
     case CachedResource::ApplicationManifest:
-        // FIXME: Support preloading the manifest.
+#endif
+        // None of these values is currently supported as an `as` value.
         ASSERT_NOT_REACHED();
-#endif
     }
     return nullptr;
 }

Modified: trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp (225746 => 225747)


--- trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp	2017-12-11 18:09:32 UTC (rev 225747)
@@ -36,6 +36,7 @@
 #include "ImageDecoder.h"
 #include "MemoryCache.h"
 #include "SecurityPolicy.h"
+#include "ServiceWorkerRegistrationData.h"
 #include <wtf/NeverDestroyed.h>
 
 namespace WebCore {

Modified: trunk/Source/WebKit/ChangeLog (225746 => 225747)


--- trunk/Source/WebKit/ChangeLog	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebKit/ChangeLog	2017-12-11 18:09:32 UTC (rev 225747)
@@ -1,3 +1,13 @@
+2017-12-11  David Quesada  <[email protected]>
+
+        Turn on ENABLE_APPLICATION_MANIFEST
+        https://bugs.webkit.org/show_bug.cgi?id=180562
+        rdar://problem/35924737
+
+        Reviewed by Geoffrey Garen.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-11  Dean Jackson  <[email protected]>
 
         Add a runtime feature flag for ImageBitmap and OffscreenCanvas

Modified: trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig (225746 => 225747)


--- trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2017-12-11 18:09:32 UTC (rev 225747)
@@ -66,7 +66,7 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
-ENABLE_APPLICATION_MANIFEST = ;
+ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
 ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING;

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (225746 => 225747)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-11 18:09:32 UTC (rev 225747)
@@ -1,3 +1,13 @@
+2017-12-11  David Quesada  <[email protected]>
+
+        Turn on ENABLE_APPLICATION_MANIFEST
+        https://bugs.webkit.org/show_bug.cgi?id=180562
+        rdar://problem/35924737
+
+        Reviewed by Geoffrey Garen.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-08  Yusuke Suzuki  <[email protected]>
 
         Remove pthread_once in favor of dispatch_once

Modified: trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (225746 => 225747)


--- trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2017-12-11 18:09:32 UTC (rev 225747)
@@ -66,7 +66,7 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
-ENABLE_APPLICATION_MANIFEST = ;
+ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
 ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING;

Modified: trunk/Tools/ChangeLog (225746 => 225747)


--- trunk/Tools/ChangeLog	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Tools/ChangeLog	2017-12-11 18:09:32 UTC (rev 225747)
@@ -1,3 +1,13 @@
+2017-12-11  David Quesada  <[email protected]>
+
+        Turn on ENABLE_APPLICATION_MANIFEST
+        https://bugs.webkit.org/show_bug.cgi?id=180562
+        rdar://problem/35924737
+
+        Reviewed by Geoffrey Garen.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-11  Zan Dobersek  <[email protected]>
 
         Unreviewed, rolling out r225737.

Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (225746 => 225747)


--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-12-11 18:07:48 UTC (rev 225746)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-12-11 18:09:32 UTC (rev 225747)
@@ -66,7 +66,7 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
-ENABLE_APPLICATION_MANIFEST = ;
+ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
 ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to