Title: [225806] trunk/Source/WebInspectorUI
- Revision
- 225806
- Author
- mcatanz...@igalia.com
- Date
- 2017-12-12 14:23:17 -0800 (Tue, 12 Dec 2017)
Log Message
Don't require perl(File::Copy::Recursive)
https://bugs.webkit.org/show_bug.cgi?id=180479
<rdar://problem/35944218>
Reviewed by Daniel Bates.
Fix the error handling. I added this at the last moment and failed to test. The logic is
inverted, causing an error to always be reported on success.
Add a missing 'mkdir -p' using File::Path::make_path. This has its own built-in error
reporting, so no need to add our own.
* Scripts/copy-user-interface-resources.pl:
(ditto):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (225805 => 225806)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-12-12 22:19:20 UTC (rev 225805)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-12-12 22:23:17 UTC (rev 225806)
@@ -1,5 +1,22 @@
2017-12-12 Michael Catanzaro <mcatanz...@igalia.com>
+ Don't require perl(File::Copy::Recursive)
+ https://bugs.webkit.org/show_bug.cgi?id=180479
+ <rdar://problem/35944218>
+
+ Reviewed by Daniel Bates.
+
+ Fix the error handling. I added this at the last moment and failed to test. The logic is
+ inverted, causing an error to always be reported on success.
+
+ Add a missing 'mkdir -p' using File::Path::make_path. This has its own built-in error
+ reporting, so no need to add our own.
+
+ * Scripts/copy-user-interface-resources.pl:
+ (ditto):
+
+2017-12-12 Michael Catanzaro <mcatanz...@igalia.com>
+
Unreviewed, don't print empty error message when copying resource fails
Unsurprisingly, when system() fails, there is not any useful error to be printed, so don't.
Modified: trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl (225805 => 225806)
--- trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2017-12-12 22:19:20 UTC (rev 225805)
+++ trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2017-12-12 22:23:17 UTC (rev 225806)
@@ -49,9 +49,10 @@
} elsif ($^O ne 'MSWin32') {
# Ditto copies the *contents* of the source directory, not the directory itself.
opendir(my $dh, $source) or die "Can't open $source: $!";
+ make_path($destination);
while (readdir $dh) {
if ($_ ne '..' and $_ ne '.') {
- system('cp', '-R', "${source}/$_", $destination) or die "Failed to copy ${source}/$_ to $destination";
+ system('cp', '-R', "${source}/$_", $destination) == 0 or die "Failed to copy ${source}/$_ to $destination";
}
}
closedir $dh;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
