Title: [225870] trunk/Tools
- Revision
- 225870
- Author
- [email protected]
- Date
- 2017-12-13 13:46:24 -0800 (Wed, 13 Dec 2017)
Log Message
Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
https://bugs.webkit.org/show_bug.cgi?id=180713
<rdar://problem/36003031>
Patch by Youenn Fablet <[email protected]> on 2017-12-13
Reviewed by Andy Estes.
Reenable the check for non High Sierra builds.
* TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (225869 => 225870)
--- trunk/Tools/ChangeLog 2017-12-13 21:16:34 UTC (rev 225869)
+++ trunk/Tools/ChangeLog 2017-12-13 21:46:24 UTC (rev 225870)
@@ -1,3 +1,16 @@
+2017-12-13 Youenn Fablet <[email protected]>
+
+ Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
+ https://bugs.webkit.org/show_bug.cgi?id=180713
+ <rdar://problem/36003031>
+
+ Reviewed by Andy Estes.
+
+ Reenable the check for non High Sierra builds.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
+ (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
+
2017-12-13 Brady Eidson <[email protected]>
REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm (225869 => 225870)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm 2017-12-13 21:16:34 UTC (rev 225869)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm 2017-12-13 21:46:24 UTC (rev 225870)
@@ -364,10 +364,12 @@
#endif
#if HAVE(NETWORK_EXTENSION)
// FIXME: Libwebrtc is linking on some configurations to VideoProcessing framework which brings up NetworkExtension framework.
+ // Disable this test until we find a more robust test or libwebrtc weak link VideoProcessing framework.
// https://bugs.webkit.org/show_bug.cgi?id=180713
- // Disable this test until we find a more robust test or libwebrtc weak link VideoProcessing framework.
- // EXPECT_EQ(static_cast<bool>(networkExtensionShouldBeLoaded), static_cast<bool>(networkExtensionLoaded));
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300
+ EXPECT_EQ(static_cast<bool>(networkExtensionShouldBeLoaded), static_cast<bool>(networkExtensionLoaded));
#endif
+#endif // HAVE(NETWORK_EXTENSION)
isDone = true;
}];
TestWebKitAPI::Util::run(&isDone);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
