Title: [225912] trunk/Source/bmalloc
- Revision
- 225912
- Author
- [email protected]
- Date
- 2017-12-14 11:10:54 -0800 (Thu, 14 Dec 2017)
Log Message
logVMFailure should not simulate crash on iOS
https://bugs.webkit.org/show_bug.cgi?id=180790
Reviewed by JF Bastien.
The Gigacage allocation on iOS is expected to fail in certain circumstances.
Let's not simulate a crash on failure because since this is expected behavior.
* bmalloc/VMAllocate.h:
(bmalloc::tryVMAllocate):
Modified Paths
Diff
Modified: trunk/Source/bmalloc/ChangeLog (225911 => 225912)
--- trunk/Source/bmalloc/ChangeLog 2017-12-14 19:08:32 UTC (rev 225911)
+++ trunk/Source/bmalloc/ChangeLog 2017-12-14 19:10:54 UTC (rev 225912)
@@ -1,3 +1,16 @@
+2017-12-14 Saam Barati <[email protected]>
+
+ logVMFailure should not simulate crash on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=180790
+
+ Reviewed by JF Bastien.
+
+ The Gigacage allocation on iOS is expected to fail in certain circumstances.
+ Let's not simulate a crash on failure because since this is expected behavior.
+
+ * bmalloc/VMAllocate.h:
+ (bmalloc::tryVMAllocate):
+
2017-12-11 Tim Horton <[email protected]>
Stop using deprecated target conditional for simulator builds
Modified: trunk/Source/bmalloc/bmalloc/VMAllocate.h (225911 => 225912)
--- trunk/Source/bmalloc/bmalloc/VMAllocate.h 2017-12-14 19:08:32 UTC (rev 225911)
+++ trunk/Source/bmalloc/bmalloc/VMAllocate.h 2017-12-14 19:10:54 UTC (rev 225912)
@@ -122,10 +122,8 @@
{
vmValidate(vmSize);
void* result = mmap(0, vmSize, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANON | BMALLOC_NORESERVE, BMALLOC_VM_TAG, 0);
- if (result == MAP_FAILED) {
- logVMFailure(vmSize);
+ if (result == MAP_FAILED)
return nullptr;
- }
return result;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
