Title: [225973] trunk/Source/WebCore
- Revision
- 225973
- Author
- [email protected]
- Date
- 2017-12-15 07:38:29 -0800 (Fri, 15 Dec 2017)
Log Message
WebRTC Stats should not be console logged from a background thread
https://bugs.webkit.org/show_bug.cgi?id=180845
Patch by Youenn Fablet <[email protected]> on 2017-12-15
Reviewed by Eric Carlson.
Ensuring console log are done in the main thread.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (225972 => 225973)
--- trunk/Source/WebCore/ChangeLog 2017-12-15 14:27:25 UTC (rev 225972)
+++ trunk/Source/WebCore/ChangeLog 2017-12-15 15:38:29 UTC (rev 225973)
@@ -1,3 +1,15 @@
+2017-12-15 Youenn Fablet <[email protected]>
+
+ WebRTC Stats should not be console logged from a background thread
+ https://bugs.webkit.org/show_bug.cgi?id=180845
+
+ Reviewed by Eric Carlson.
+
+ Ensuring console log are done in the main thread.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+ (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+
2017-12-15 Antti Koivisto <[email protected]>
Introduce RenderTreeBuilder
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (225972 => 225973)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-12-15 14:27:25 UTC (rev 225972)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-12-15 15:38:29 UTC (rev 225973)
@@ -1082,19 +1082,19 @@
if (!m_statsFirstDeliveredTimestamp)
m_statsFirstDeliveredTimestamp = timestamp;
- if (m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
- callOnMainThread([protectedThis = makeRef(*this), this, timestamp] {
+ callOnMainThread([protectedThis = makeRef(*this), this, timestamp, report] {
+ if (m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
m_statsLogTimer.stop();
m_statsLogTimer.startRepeating(statsLogInterval(timestamp));
- });
- }
+ }
- for (auto iterator = report->begin(); iterator != report->end(); ++iterator) {
- if (iterator->type() == webrtc::RTCCodecStats::kType)
- continue;
+ for (auto iterator = report->begin(); iterator != report->end(); ++iterator) {
+ if (iterator->type() == webrtc::RTCCodecStats::kType)
+ continue;
- ALWAYS_LOG(LOGIDENTIFIER, "WebRTC stats for :", *iterator);
- }
+ ALWAYS_LOG(LOGIDENTIFIER, "WebRTC stats for :", *iterator);
+ }
+ });
#else
UNUSED_PARAM(report);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
