Title: [226014] trunk
- Revision
- 226014
- Author
- [email protected]
- Date
- 2017-12-17 13:15:28 -0800 (Sun, 17 Dec 2017)
Log Message
Strip fragment identifier from ServiceWorker's scriptURL
https://bugs.webkit.org/show_bug.cgi?id=180887
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT test now that one more check is passing.
* web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https-expected.txt:
Source/WebCore:
Strip fragment identifier from ServiceWorker's scriptURL to match Firefox and Chrome.
This behavior does not appear to be specified so I filed:
- https://github.com/w3c/ServiceWorker/issues/1249
No new tests, rebaselined existing test.
* workers/service/server/SWServerWorker.cpp:
(WebCore::m_script):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226013 => 226014)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-17 21:11:27 UTC (rev 226013)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-17 21:15:28 UTC (rev 226014)
@@ -1,3 +1,14 @@
+2017-12-17 Chris Dumez <[email protected]>
+
+ Strip fragment identifier from ServiceWorker's scriptURL
+ https://bugs.webkit.org/show_bug.cgi?id=180887
+
+ Reviewed by Darin Adler.
+
+ Rebaseline WPT test now that one more check is passing.
+
+ * web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https-expected.txt:
+
2017-12-16 Romain Bellessort <[email protected]>
[Readable Streams API] Fix filling of descriptor from queue
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https-expected.txt (226013 => 226014)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https-expected.txt 2017-12-17 21:11:27 UTC (rev 226013)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https-expected.txt 2017-12-17 21:15:28 UTC (rev 226014)
@@ -1,5 +1,5 @@
PASS Verify the scriptURL property: relative
-FAIL Verify the scriptURL property: with-fragment assert_equals: Returned ServiceWorker object should have scriptURL expected "https://localhost:9443/service-workers/service-worker/resources/empty-worker.js" but got "https://localhost:9443/service-workers/service-worker/resources/empty-worker.js#ref"
+PASS Verify the scriptURL property: with-fragment
PASS Verify the scriptURL property: absolute
Modified: trunk/Source/WebCore/ChangeLog (226013 => 226014)
--- trunk/Source/WebCore/ChangeLog 2017-12-17 21:11:27 UTC (rev 226013)
+++ trunk/Source/WebCore/ChangeLog 2017-12-17 21:15:28 UTC (rev 226014)
@@ -1,3 +1,19 @@
+2017-12-17 Chris Dumez <[email protected]>
+
+ Strip fragment identifier from ServiceWorker's scriptURL
+ https://bugs.webkit.org/show_bug.cgi?id=180887
+
+ Reviewed by Darin Adler.
+
+ Strip fragment identifier from ServiceWorker's scriptURL to match Firefox and Chrome.
+ This behavior does not appear to be specified so I filed:
+ - https://github.com/w3c/ServiceWorker/issues/1249
+
+ No new tests, rebaselined existing test.
+
+ * workers/service/server/SWServerWorker.cpp:
+ (WebCore::m_script):
+
2017-12-17 Antti Koivisto <[email protected]>
Move render tree updating related files under rendering/updating/
Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp (226013 => 226014)
--- trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp 2017-12-17 21:11:27 UTC (rev 226013)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp 2017-12-17 21:15:28 UTC (rev 226014)
@@ -50,6 +50,8 @@
, m_data { identifier, scriptURL, ServiceWorkerState::Redundant, type, registration.identifier() }
, m_script(script)
{
+ m_data.scriptURL.removeFragmentIdentifier();
+
auto result = allWorkers().add(identifier, this);
ASSERT_UNUSED(result, result.isNewEntry);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
