Title: [226055] releases/WebKitGTK/webkit-2.18/Source/WebDriver
- Revision
- 226055
- Author
- [email protected]
- Date
- 2017-12-18 09:40:49 -0800 (Mon, 18 Dec 2017)
Log Message
Merge r225739 - WebDriver: get active element should return no such element error when there isn't an active element
https://bugs.webkit.org/show_bug.cgi?id=180421
Reviewed by Brian Burg.
We currently return unknown error.
Fixes: imported/w3c/webdriver/tests/element_retrieval/get_active_element.py::test_missing_document_element
* Session.cpp:
(WebDriver::Session::getActiveElement):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/Source/WebDriver/ChangeLog (226054 => 226055)
--- releases/WebKitGTK/webkit-2.18/Source/WebDriver/ChangeLog 2017-12-18 17:35:28 UTC (rev 226054)
+++ releases/WebKitGTK/webkit-2.18/Source/WebDriver/ChangeLog 2017-12-18 17:40:49 UTC (rev 226055)
@@ -1,3 +1,17 @@
+2017-12-11 Carlos Garcia Campos <[email protected]>
+
+ WebDriver: get active element should return no such element error when there isn't an active element
+ https://bugs.webkit.org/show_bug.cgi?id=180421
+
+ Reviewed by Brian Burg.
+
+ We currently return unknown error.
+
+ Fixes: imported/w3c/webdriver/tests/element_retrieval/get_active_element.py::test_missing_document_element
+
+ * Session.cpp:
+ (WebDriver::Session::getActiveElement):
+
2017-12-04 Carlos Garcia Campos <[email protected]>
WebDriver: implement element property command
Modified: releases/WebKitGTK/webkit-2.18/Source/WebDriver/Session.cpp (226054 => 226055)
--- releases/WebKitGTK/webkit-2.18/Source/WebDriver/Session.cpp 2017-12-18 17:35:28 UTC (rev 226054)
+++ releases/WebKitGTK/webkit-2.18/Source/WebDriver/Session.cpp 2017-12-18 17:40:49 UTC (rev 226055)
@@ -996,7 +996,7 @@
}
RefPtr<JSON::Object> elementObject = createElement(WTFMove(resultValue));
if (!elementObject) {
- completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
+ completionHandler(CommandResult::fail(CommandResult::ErrorCode::NoSuchElement));
return;
}
completionHandler(CommandResult::success(WTFMove(elementObject)));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
