Title: [226086] trunk
- Revision
- 226086
- Author
- [email protected]
- Date
- 2017-12-18 16:28:44 -0800 (Mon, 18 Dec 2017)
Log Message
ExtendableMessageEvent constructor fails to initialize the 'source' attribute
https://bugs.webkit.org/show_bug.cgi?id=180954
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline WPT test now that more checks are passing.
* web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt:
Source/WebCore:
No new tests, rebaselined existing test.
* workers/service/ExtendableMessageEvent.cpp:
(WebCore::ExtendableMessageEvent::ExtendableMessageEvent):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226085 => 226086)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-19 00:19:17 UTC (rev 226085)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-19 00:28:44 UTC (rev 226086)
@@ -1,3 +1,14 @@
+2017-12-18 Chris Dumez <[email protected]>
+
+ ExtendableMessageEvent constructor fails to initialize the 'source' attribute
+ https://bugs.webkit.org/show_bug.cgi?id=180954
+
+ Reviewed by Youenn Fablet.
+
+ Rebaseline WPT test now that more checks are passing.
+
+ * web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt:
+
2017-12-18 Youenn Fablet <[email protected]>
SameOrigin and CORS fetch should fail on opaque responses served from ServiceWorker
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt (226085 => 226086)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt 2017-12-19 00:19:17 UTC (rev 226085)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt 2017-12-19 00:28:44 UTC (rev 226086)
@@ -6,8 +6,8 @@
PASS `data` is specified
PASS `origin` is specified
PASS `lastEventId` is specified
-FAIL `source` is specified assert_equals: expected object "[object MessagePort]" but got null
+PASS `source` is specified
FAIL `ports` is specified assert_throws: function "function () {
createEvent({ get ports() { throw { name: 'Error' }; } }); }" threw object "TypeError: Value is not a sequence" ("TypeError") expected object "[object Object]" ("Error")
-FAIL all initial values are specified assert_equals: expected object "[object MessagePort]" but got null
+PASS all initial values are specified
Modified: trunk/Source/WebCore/ChangeLog (226085 => 226086)
--- trunk/Source/WebCore/ChangeLog 2017-12-19 00:19:17 UTC (rev 226085)
+++ trunk/Source/WebCore/ChangeLog 2017-12-19 00:28:44 UTC (rev 226086)
@@ -1,3 +1,15 @@
+2017-12-18 Chris Dumez <[email protected]>
+
+ ExtendableMessageEvent constructor fails to initialize the 'source' attribute
+ https://bugs.webkit.org/show_bug.cgi?id=180954
+
+ Reviewed by Youenn Fablet.
+
+ No new tests, rebaselined existing test.
+
+ * workers/service/ExtendableMessageEvent.cpp:
+ (WebCore::ExtendableMessageEvent::ExtendableMessageEvent):
+
2017-12-18 Wenson Hsieh <[email protected]>
[Attachment Support] Insert images as inline attachments when pasting and dropping
Modified: trunk/Source/WebCore/workers/service/ExtendableMessageEvent.cpp (226085 => 226086)
--- trunk/Source/WebCore/workers/service/ExtendableMessageEvent.cpp 2017-12-19 00:19:17 UTC (rev 226085)
+++ trunk/Source/WebCore/workers/service/ExtendableMessageEvent.cpp 2017-12-19 00:28:44 UTC (rev 226086)
@@ -42,6 +42,7 @@
, m_data(SerializedScriptValue::create(state, init.data, SerializationErrorMode::NonThrowing))
, m_origin(init.origin)
, m_lastEventId(init.lastEventId)
+ , m_source(init.source)
, m_ports(init.ports)
{
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
