Title: [226091] trunk/Source/WebKitLegacy/win
- Revision
- 226091
- Author
- [email protected]
- Date
- 2017-12-18 18:09:10 -0800 (Mon, 18 Dec 2017)
Log Message
[Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
https://bugs.webkit.org/show_bug.cgi?id=180926
Patch by Fujii Hironori <[email protected]> on 2017-12-18
Reviewed by Tim Horton.
Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
(WebFrameLoaderClient::pageID const): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (226090 => 226091)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2017-12-19 01:55:40 UTC (rev 226090)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2017-12-19 02:09:10 UTC (rev 226091)
@@ -1,3 +1,17 @@
+2017-12-18 Fujii Hironori <[email protected]>
+
+ [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
+ https://bugs.webkit.org/show_bug.cgi?id=180926
+
+ Reviewed by Tim Horton.
+
+ Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
+ of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
+
+ * WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
+ (WebFrameLoaderClient::pageID const): Ditto.
+
2017-12-16 Yusuke Suzuki <[email protected]>
Remove unnecessary boolean result of start() functions
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp (226090 => 226091)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp 2017-12-19 01:55:40 UTC (rev 226090)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp 2017-12-19 02:09:10 UTC (rev 226091)
@@ -123,13 +123,11 @@
std::optional<uint64_t> WebFrameLoaderClient::pageID() const
{
- RELEASE_ASSERT_NOT_REACHED();
return std::nullopt;
}
std::optional<uint64_t> WebFrameLoaderClient::frameID() const
{
- RELEASE_ASSERT_NOT_REACHED();
return std::nullopt;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
