Title: [226109] releases/WebKitGTK/webkit-2.18/Source/WebKit
- Revision
- 226109
- Author
- [email protected]
- Date
- 2017-12-19 00:03:59 -0800 (Tue, 19 Dec 2017)
Log Message
Merge r225676 - [GTK] WebInspectorProxyClient needs a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=180533
Reviewed by Carlos Garcia Campos.
Otherwise the derived class portion of the object, WebKitInspectorClient, is not destroyed.
* UIProcess/gtk/WebInspectorProxyClient.h:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/Source/WebKit/ChangeLog (226108 => 226109)
--- releases/WebKitGTK/webkit-2.18/Source/WebKit/ChangeLog 2017-12-19 08:03:07 UTC (rev 226108)
+++ releases/WebKitGTK/webkit-2.18/Source/WebKit/ChangeLog 2017-12-19 08:03:59 UTC (rev 226109)
@@ -1,3 +1,14 @@
+2017-12-08 Michael Catanzaro <[email protected]>
+
+ [GTK] WebInspectorProxyClient needs a virtual destructor
+ https://bugs.webkit.org/show_bug.cgi?id=180533
+
+ Reviewed by Carlos Garcia Campos.
+
+ Otherwise the derived class portion of the object, WebKitInspectorClient, is not destroyed.
+
+ * UIProcess/gtk/WebInspectorProxyClient.h:
+
2017-11-29 Michael Catanzaro <[email protected]>
REGRESSION(r218064): [GTK] Broke entering fullscreen mode in debug builds
Modified: releases/WebKitGTK/webkit-2.18/Source/WebKit/UIProcess/gtk/WebInspectorProxyClient.h (226108 => 226109)
--- releases/WebKitGTK/webkit-2.18/Source/WebKit/UIProcess/gtk/WebInspectorProxyClient.h 2017-12-19 08:03:07 UTC (rev 226108)
+++ releases/WebKitGTK/webkit-2.18/Source/WebKit/UIProcess/gtk/WebInspectorProxyClient.h 2017-12-19 08:03:59 UTC (rev 226109)
@@ -33,6 +33,7 @@
class WebInspectorProxyClient {
public:
+ virtual ~WebInspectorProxyClient() = default;
virtual bool openWindow(WebInspectorProxy&) = 0;
virtual void didClose(WebInspectorProxy&) = 0;
virtual bool bringToFront(WebInspectorProxy&) = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
