Title: [226190] trunk/Source/WebCore
- Revision
- 226190
- Author
- [email protected]
- Date
- 2017-12-20 10:55:53 -0800 (Wed, 20 Dec 2017)
Log Message
Send fullscreenChange earlier, in webkitWillEnterFullscreen
https://bugs.webkit.org/show_bug.cgi?id=181016
Patch by Jeremy Jones <[email protected]> on 2017-12-20
Reviewed by Jer Noble.
Sending the event earlier, allows pages to update their interface state before the fullscreen animation.
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (226189 => 226190)
--- trunk/Source/WebCore/ChangeLog 2017-12-20 18:43:22 UTC (rev 226189)
+++ trunk/Source/WebCore/ChangeLog 2017-12-20 18:55:53 UTC (rev 226190)
@@ -1,3 +1,16 @@
+2017-12-20 Jeremy Jones <[email protected]>
+
+ Send fullscreenChange earlier, in webkitWillEnterFullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=181016
+
+ Reviewed by Jer Noble.
+
+ Sending the event earlier, allows pages to update their interface state before the fullscreen animation.
+
+ * dom/Document.cpp:
+ (WebCore::Document::webkitWillEnterFullScreenForElement):
+ (WebCore::Document::webkitDidEnterFullScreenForElement):
+
2017-12-20 Daniel Bates <[email protected]>
Remove Alternative Presentation Button
Modified: trunk/Source/WebCore/dom/Document.cpp (226189 => 226190)
--- trunk/Source/WebCore/dom/Document.cpp 2017-12-20 18:43:22 UTC (rev 226189)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-12-20 18:55:53 UTC (rev 226190)
@@ -6213,6 +6213,9 @@
m_fullScreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(true);
resolveStyle(ResolveStyleType::Rebuild);
+#if PLATFORM(IOS) && ENABLE(FULLSCREEN_API)
+ m_fullScreenChangeDelayTimer.startOneShot(0_s);
+#endif
}
void Document::webkitDidEnterFullScreenForElement(Element*)
@@ -6225,7 +6228,9 @@
m_fullScreenElement->didBecomeFullscreenElement();
+#if !PLATFORM(IOS) || !ENABLE(FULLSCREEN_API)
m_fullScreenChangeDelayTimer.startOneShot(0_s);
+#endif
}
void Document::webkitWillExitFullScreenForElement(Element*)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
