Title: [226220] trunk/Source/WebCore
- Revision
- 226220
- Author
- [email protected]
- Date
- 2017-12-21 06:51:49 -0800 (Thu, 21 Dec 2017)
Log Message
Replace a FIXME comment in CanvasGradient::addColorStop().
https://bugs.webkit.org/show_bug.cgi?id=181034
Reviewed by Daniel Bates.
Tests: LayoutTests/imported/w3c/canvas/2d.gradient.object.current.html
* html/canvas/CanvasGradient.cpp:
(WebCore::CanvasGradient::addColorStop):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (226219 => 226220)
--- trunk/Source/WebCore/ChangeLog 2017-12-21 14:44:47 UTC (rev 226219)
+++ trunk/Source/WebCore/ChangeLog 2017-12-21 14:51:49 UTC (rev 226220)
@@ -1,3 +1,15 @@
+2017-12-21 Ms2ger <[email protected]>
+
+ Replace a FIXME comment in CanvasGradient::addColorStop().
+ https://bugs.webkit.org/show_bug.cgi?id=181034
+
+ Reviewed by Daniel Bates.
+
+ Tests: LayoutTests/imported/w3c/canvas/2d.gradient.object.current.html
+
+ * html/canvas/CanvasGradient.cpp:
+ (WebCore::CanvasGradient::addColorStop):
+
2017-12-21 Jeremy Jones <[email protected]>
Enable picture-in-picture from inline element on suspend.
Modified: trunk/Source/WebCore/html/canvas/CanvasGradient.cpp (226219 => 226220)
--- trunk/Source/WebCore/html/canvas/CanvasGradient.cpp 2017-12-21 14:44:47 UTC (rev 226219)
+++ trunk/Source/WebCore/html/canvas/CanvasGradient.cpp 2017-12-21 14:51:49 UTC (rev 226220)
@@ -46,7 +46,8 @@
if (!(value >= 0 && value <= 1))
return Exception { IndexSizeError };
- // FIXME: Passing null for canvas means this won't work for current color. Is that OK?
+ // Passing null for canvas ensures that currentColor is treated as black,
+ // as required by the standard.
Color color = parseColorOrCurrentColor(colorString, nullptr /*canvas*/);
if (!color.isValid()) {
#if ENABLE(DASHBOARD_SUPPORT)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
