[webkit-changes] [226239] trunk

Thu, 21 Dec 2017 13:10:42 -0800

Title: [226239] trunk
Revision
226239
Author
[email protected]
Date
2017-12-21 13:10:12 -0800 (Thu, 21 Dec 2017)

Log Message

Update FULLSCREEN_API feature defines.
https://bugs.webkit.org/show_bug.cgi?id=181015

Patch by Jeremy Jones <[email protected]> on 2017-12-21
Reviewed by Tim Horton.

Change enabled iphone sdk for FULLSCREEN_API.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226238 => 226239)


--- trunk/Source/_javascript_Core/ChangeLog	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-21 21:10:12 UTC (rev 226239)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <[email protected]>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-19  Yusuke Suzuki  <[email protected]>
 
         [JSC] Do not check isValid() in op_new_regexp

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (226238 => 226239)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-12-21 21:10:12 UTC (rev 226239)
@@ -64,6 +64,15 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;

Modified: trunk/Source/WebCore/ChangeLog (226238 => 226239)


--- trunk/Source/WebCore/ChangeLog	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebCore/ChangeLog	2017-12-21 21:10:12 UTC (rev 226239)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <[email protected]>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Chris Dumez  <[email protected]>
 
         ononline, onoffline and navigator.onLine don't work if Parallels or VMWare is installed

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (226238 => 226239)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-12-21 21:10:12 UTC (rev 226239)
@@ -64,6 +64,15 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;

Modified: trunk/Source/WebCore/PAL/ChangeLog (226238 => 226239)


--- trunk/Source/WebCore/PAL/ChangeLog	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-12-21 21:10:12 UTC (rev 226239)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <[email protected]>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Brent Fulgham  <[email protected]>
 
         Adopt new secure coding APIs in WebCore

Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (226238 => 226239)


--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-12-21 21:10:12 UTC (rev 226239)
@@ -64,6 +64,15 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;

Modified: trunk/Source/WebKit/ChangeLog (226238 => 226239)


--- trunk/Source/WebKit/ChangeLog	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebKit/ChangeLog	2017-12-21 21:10:12 UTC (rev 226239)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <[email protected]>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  John Wilander  <[email protected]>
 
         Storage Access API: Make DocumentLoader::willSendRequest() and WebFrameLoaderClient::detachedFromParent2() tell the network process to get rid of any sub frame access entries

Modified: trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig (226238 => 226239)


--- trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2017-12-21 21:10:12 UTC (rev 226239)
@@ -64,6 +64,15 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (226238 => 226239)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2017-12-21 21:10:12 UTC (rev 226239)
@@ -4866,6 +4866,7 @@
 
 #if PLATFORM(IOS)
 
+#if ENABLE(FULLSCREEN_API)
 - (void)removeFromSuperview
 {
     [super removeFromSuperview];
@@ -4873,6 +4874,7 @@
     if ([_fullScreenWindowController isFullScreen])
         [_fullScreenWindowController webViewDidRemoveFromSuperviewWhileInFullscreen];
 }
+#endif
 
 - (CGSize)_minimumLayoutSizeOverride
 {

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (226238 => 226239)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-21 21:10:12 UTC (rev 226239)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <[email protected]>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Jer Noble  <[email protected]>
 
         Add initial DOM support for Media Capabilities

Modified: trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (226238 => 226239)


--- trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2017-12-21 21:10:12 UTC (rev 226239)
@@ -64,6 +64,15 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;

Modified: trunk/Tools/ChangeLog (226238 => 226239)


--- trunk/Tools/ChangeLog	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Tools/ChangeLog	2017-12-21 21:10:12 UTC (rev 226239)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <[email protected]>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Don Olmstead  <[email protected]>
 
         [AppleWin] Auxiliary libraries should be updated within build-webkit

Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (226238 => 226239)


--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-12-21 21:00:50 UTC (rev 226238)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-12-21 21:10:12 UTC (rev 226239)
@@ -64,6 +64,15 @@
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to