Title: [226303] trunk/Websites/perf.webkit.org
- Revision
- 226303
- Author
- [email protected]
- Date
- 2017-12-27 14:55:43 -0800 (Wed, 27 Dec 2017)
Log Message
Test freshness page should use build time instead of commit time to determine the freshness of the data point.
https://bugs.webkit.org/show_bug.cgi?id=181156
Reviewed by Alexey Proskuryakov.
Build time is a better data point freshness indicator. Test freshness page is designed to highlight test failures.
Using commit time will result in including the compiling and test running time which does not quite match the
definition of data point fresshness.
* public/v3/pages/test-freshness-page.js:
(TestFreshnessPage.prototype._fetchTestResults): Use build time instead of commit time.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (226302 => 226303)
--- trunk/Websites/perf.webkit.org/ChangeLog 2017-12-27 17:41:19 UTC (rev 226302)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-12-27 22:55:43 UTC (rev 226303)
@@ -1,3 +1,17 @@
+2017-12-26 Dewei Zhu <[email protected]>
+
+ Test freshness page should use build time instead of commit time to determine the freshness of the data point.
+ https://bugs.webkit.org/show_bug.cgi?id=181156
+
+ Reviewed by Alexey Proskuryakov.
+
+ Build time is a better data point freshness indicator. Test freshness page is designed to highlight test failures.
+ Using commit time will result in including the compiling and test running time which does not quite match the
+ definition of data point fresshness.
+
+ * public/v3/pages/test-freshness-page.js:
+ (TestFreshnessPage.prototype._fetchTestResults): Use build time instead of commit time.
+
2017-12-21 Dewei Zhu <[email protected]>
Add UI for A/B testing on owned commits.
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js (226302 => 226303)
--- trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2017-12-27 17:41:19 UTC (rev 226302)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2017-12-27 22:55:43 UTC (rev 226303)
@@ -72,7 +72,7 @@
let timeForLastDataPoint = startTime;
if (currentTimeSeries.lastPoint())
- timeForLastDataPoint = currentTimeSeries.lastPoint().time;
+ timeForLastDataPoint = currentTimeSeries.lastPoint().build().buildTime();
lastDataPointByMetric.set(metric, {time: timeForLastDataPoint, hasCurrentDataPoint: !!currentTimeSeries.lastPoint()});
this.enqueueToRender();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
