Modified: trunk/Tools/ChangeLog (226325 => 226326)
--- trunk/Tools/ChangeLog 2018-01-02 17:21:37 UTC (rev 226325)
+++ trunk/Tools/ChangeLog 2018-01-02 18:17:07 UTC (rev 226326)
@@ -1,3 +1,18 @@
+2018-01-02 Michael Catanzaro <[email protected]>
+
+ [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=168194
+
+ Reviewed by Carlos Garcia Campos.
+
+ Fix an assertion and unskip the test. The order that form controls are associated is not
+ guaranteed.
+
+ * Scripts/run-gtk-tests:
+ (GtkTestRunner):
+ * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+ (didAssociateFormControlsCallback):
+
2018-01-02 Alex Christensen <[email protected]>
Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
Modified: trunk/Tools/Scripts/run-gtk-tests (226325 => 226326)
--- trunk/Tools/Scripts/run-gtk-tests 2018-01-02 17:21:37 UTC (rev 226325)
+++ trunk/Tools/Scripts/run-gtk-tests 2018-01-02 18:17:07 UTC (rev 226326)
@@ -41,7 +41,6 @@
SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
SkippedTest("WebKit2Gtk/TestPrinting", "/webkit2/WebKitPrintOperation/custom-widget", "Test is flaky", 168196),
SkippedTest("WebKit2Gtk/TestWebViewEditor", "/webkit2/WebKitWebView/editable/editable", "Test hits an assertion in Debug builds", 151654, "Debug"),
- SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebExtension/form-controls-associated-signal", "Test is flaky", 168194),
SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebView/install-missing-plugins-permission-request", "Test times out", 147822),
SkippedTest("WebKit/TestWebKit", "WebKit.MouseMoveAfterCrash", "Test is flaky", 85066),
SkippedTest("WebKit/TestWebKit", "WebKit.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp (226325 => 226326)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp 2018-01-02 17:21:37 UTC (rev 226325)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp 2018-01-02 18:17:07 UTC (rev 226326)
@@ -223,7 +223,7 @@
{
const char* formIds;
g_variant_get(result, "(&s)", &formIds);
- g_assert(!g_strcmp0(formIds, FORM_ID FORM2_ID) || !g_strcmp0(formIds, INPUT_ID));
+ g_assert(!g_strcmp0(formIds, FORM_ID FORM2_ID) || !g_strcmp0(formIds, FORM2_ID FORM_ID) || !g_strcmp0(formIds, INPUT_ID));
test->quitMainLoop();
}
