Title: [226381] trunk/Source/_javascript_Core
Revision
226381
Author
[email protected]
Date
2018-01-03 16:47:15 -0800 (Wed, 03 Jan 2018)

Log Message

Remove unnecessary flushing of Butterfly pointer in functionCpuClflush()
https://bugs.webkit.org/show_bug.cgi?id=181263

Reviewed by Mark Lam.

Flushing the butterfly pointer provides no benefit and slows this function.

* tools/JSDollarVM.cpp:
(JSC::functionCpuClflush):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226380 => 226381)


--- trunk/Source/_javascript_Core/ChangeLog	2018-01-04 00:46:52 UTC (rev 226380)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-04 00:47:15 UTC (rev 226381)
@@ -1,3 +1,15 @@
+2018-01-03  Michael Saboff  <[email protected]>
+
+        Remove unnecessary flushing of Butterfly pointer in functionCpuClflush()
+        https://bugs.webkit.org/show_bug.cgi?id=181263
+
+        Reviewed by Mark Lam.
+
+        Flushing the butterfly pointer provides no benefit and slows this function.
+
+        * tools/JSDollarVM.cpp:
+        (JSC::functionCpuClflush):
+
 2018-01-03  Saam Barati  <[email protected]>
 
         Fix BytecodeParser op_catch assert to work with useProfiler=1

Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (226380 => 226381)


--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp	2018-01-04 00:46:52 UTC (rev 226380)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp	2018-01-04 00:47:15 UTC (rev 226381)
@@ -1118,7 +1118,6 @@
         case ALL_INT32_INDEXING_TYPES:
         case ALL_CONTIGUOUS_INDEXING_TYPES:
         case ALL_DOUBLE_INDEXING_TYPES:
-            toFlush.append(bitwise_cast<char*>(object) + JSObject::butterflyOffset());
             toFlush.append(bitwise_cast<char*>(object->butterfly()) + Butterfly::offsetOfVectorLength());
             toFlush.append(bitwise_cast<char*>(object->butterfly()) + Butterfly::offsetOfPublicLength());
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to