Title: [226383] trunk/Source/WebCore
- Revision
- 226383
- Author
- commit-qu...@webkit.org
- Date
- 2018-01-03 16:51:00 -0800 (Wed, 03 Jan 2018)
Log Message
LayoutTest http/tests/media/media-stream/disconnected-frame.html to consistently fail an assertion: !m_adoptionIsRequired
https://bugs.webkit.org/show_bug.cgi?id=181264
Patch by Youenn Fablet <you...@apple.com> on 2018-01-03
Reviewed by Eric Carlson.
Covered by http/tests/media/media-stream/disconnected-frame.html not crashing anymore in Debug builds.
Calling suspendIfNeeded in create method instead of constructor.
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (226382 => 226383)
--- trunk/Source/WebCore/ChangeLog 2018-01-04 00:49:48 UTC (rev 226382)
+++ trunk/Source/WebCore/ChangeLog 2018-01-04 00:51:00 UTC (rev 226383)
@@ -1,3 +1,17 @@
+2018-01-03 Youenn Fablet <you...@apple.com>
+
+ LayoutTest http/tests/media/media-stream/disconnected-frame.html to consistently fail an assertion: !m_adoptionIsRequired
+ https://bugs.webkit.org/show_bug.cgi?id=181264
+
+ Reviewed by Eric Carlson.
+
+ Covered by http/tests/media/media-stream/disconnected-frame.html not crashing anymore in Debug builds.
+ Calling suspendIfNeeded in create method instead of constructor.
+
+ * Modules/mediastream/UserMediaRequest.cpp:
+ (WebCore::UserMediaRequest::create):
+ (WebCore::UserMediaRequest::UserMediaRequest):
+
2018-01-03 Antti Koivisto <an...@apple.com>
Remove DeprecatedCSSOMValue::equals
Modified: trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp (226382 => 226383)
--- trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp 2018-01-04 00:49:48 UTC (rev 226382)
+++ trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp 2018-01-04 00:51:00 UTC (rev 226383)
@@ -56,7 +56,9 @@
RefPtr<UserMediaRequest> UserMediaRequest::create(Document& document, MediaStreamRequest&& request, DOMPromiseDeferred<IDLInterface<MediaStream>>&& promise)
{
- return adoptRef(*new UserMediaRequest(document, WTFMove(request), WTFMove(promise)));
+ auto result = adoptRef(new UserMediaRequest(document, WTFMove(request), WTFMove(promise)));
+ result->suspendIfNeeded();
+ return result;
}
UserMediaRequest::UserMediaRequest(Document& document, MediaStreamRequest&& request, DOMPromiseDeferred<IDLInterface<MediaStream>>&& promise)
@@ -64,7 +66,6 @@
, m_promise(WTFMove(promise))
, m_request(WTFMove(request))
{
- suspendIfNeeded();
}
UserMediaRequest::~UserMediaRequest() = default;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
